[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 122939: Immediately hide tooltip on ToolTipArea destruction or when it becomes em
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2015-03-26 14:26:58
Message-ID: 20150326142658.17385.46754 () mimi ! kde ! org
[Download RAW message or body]
--===============0678469783366180090==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122939/
-----------------------------------------------------------
(Updated March 26, 2015, 2:26 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Changes
-------
Submitted with commit 4985a4fe6508c7219145776101eecd3d3eaeb871 by Kai Uwe Broulik to \
branch master.
Repository: plasma-framework
Description
-------
When the tooltip is empty (no text and no subtext and no mainitem) it will not show. \
However, when it becomes empty while it is shown, it stays there as a small \
rectangle.
This patch hides the tooltip immediately (so KWin's fadeout animation still has the \
proper content rather than the empty tooltip) when the area has been destroyed or its \
content becomes empty.
It access s_dialog directly not to unneccessarily create a tooltipInstance just for a \
call in the destructor or that wouldn't have effect without a tooltip anyway.
Diffs
-----
src/declarativeimports/core/tooltip.h 7a58826
src/declarativeimports/core/tooltip.cpp 40e0af5
src/declarativeimports/core/tooltipdialog.h d81dadb
src/declarativeimports/core/tooltipdialog.cpp 6c5675e
Diff: https://git.reviewboard.kde.org/r/122939/diff/
Testing
-------
Hovered KMail tray icon, closed KMail using Ctrl+Q while still hovering the icon.
Previously the tooltip would change into an empty rectangle, staying there until the \
tooltip times out, now it hides nicely.
Thanks,
Kai Uwe Broulik
--===============0678469783366180090==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122939/">https://git.reviewboard.kde.org/r/122939/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated March 26, 2015, 2:26 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 4985a4fe6508c7219145776101eecd3d3eaeb871 by Kai \
Uwe Broulik to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When the tooltip is empty (no text and no subtext and \
no mainitem) it will not show. However, when it becomes empty while it is shown, it \
stays there as a small rectangle.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch hides the \
tooltip immediately (so KWin's fadeout animation still has the proper content rather \
than the empty tooltip) when the area has been destroyed or its content becomes \
empty.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It access s_dialog directly not to unneccessarily \
create a tooltipInstance just for a call in the destructor or that wouldn't have \
effect without a tooltip anyway.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Hovered KMail tray icon, closed KMail using Ctrl+Q \
while still hovering the icon. Previously the tooltip would change into an empty \
rectangle, staying there until the tooltip times out, now it hides nicely.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/core/tooltip.h <span style="color: \
grey">(7a58826)</span></li>
<li>src/declarativeimports/core/tooltip.cpp <span style="color: \
grey">(40e0af5)</span></li>
<li>src/declarativeimports/core/tooltipdialog.h <span style="color: \
grey">(d81dadb)</span></li>
<li>src/declarativeimports/core/tooltipdialog.cpp <span style="color: \
grey">(6c5675e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122939/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0678469783366180090==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic