[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123131: Port kio_man away from kdelibs4support
From: "Alex Richardson" <arichardson.kde () gmail ! com>
Date: 2015-03-25 23:30:09
Message-ID: 20150325233009.17385.59942 () mimi ! kde ! org
[Download RAW message or body]
--===============0297143056861750898==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On März 25, 2015, 9:54 nachm., Lukáš Tinkl wrote:
> > man/kio_man.cpp, line 242
> > <https://git.reviewboard.kde.org/r/123131/diff/1/?file=356605#file356605line242>
> >
> > Not correct, this returns only user configured list of languages, whereas it \
> > previously returned the full list.
>
> Nick Shaforostoff wrote:
> please see https://projects.kde.org/projects/kde/kdesdk/lokalize/repository/revisions/master/entry/src/common/languagelistmodel.cpp \
> for the ways to get a list of all languages (there is a KDE-way and Qt-way)
So if I parse this correctly the KDE way is: \
`KConfig(QLatin1String("locale/kf5_all_languages"), KConfig::NoGlobals, \
QStandardPaths::GenericDataLocation).groupList()`? Should there be something in KI18n \
or is this sufficiently rare that we can just add "@deprecated use \
`KConfig(QLatin1String("locale/kf5_all_languages"), KConfig::NoGlobals, \
QStandardPaths::GenericDataLocation).groupList()` instead" to \
KLocale::languageList()?
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123131/#review78048
-----------------------------------------------------------
On März 25, 2015, 9:17 nachm., Alex Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123131/
> -----------------------------------------------------------
>
> (Updated März 25, 2015, 9:17 nachm.)
>
>
> Review request for KDE Frameworks, Plasma and Martin Koller.
>
>
> Repository: kio-extras
>
>
> Description
> -------
>
> Port kio_man away from kdelibs4support
>
>
> Diffs
> -----
>
> CMakeLists.txt 02ae89f2524324f758450ad368f64849e39b2f7d
> man/CMakeLists.txt cb4585a289d3f69b8a16429ce87bfce115d1cc27
> man/kio_man.cpp e8cf2d70c50c4c20adbb5a81a6213175d397b76e
> man/kmanpart.cpp 3af7fc182806e8b89297e8de884ce611c827e881
> man/man2html.cpp 3c493ba334bce890b450d7b11ab00c6e783708d4
>
> Diff: https://git.reviewboard.kde.org/r/123131/diff/
>
>
> Testing
> -------
>
> man view in kdevelop5 works
>
> Not sure about the `KLocale::global()->languageList();` -> \
> `QLocale().uiLanguages();` change though so I would like some feedback.
>
> Thanks,
>
> Alex Richardson
>
>
--===============0297143056861750898==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123131/">https://git.reviewboard.kde.org/r/123131/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On März 25th, 2015, 9:54 nachm. GMT, <b>Lukáš \
Tinkl</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123131/diff/1/?file=356605#file356605line242" \
style="color: black; font-weight: bold; text-decoration: \
underline;">man/kio_man.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">QStringList MANProtocol::manDirectories()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">242</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QStringList</span> <span class="n">languages</span> <span \
class="o">=</span> <span class="n">QLocale</span><span class="p">().</span><span \
class="n">uiLanguages</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Not \
correct, this returns only user configured list of languages, whereas it previously \
returned the full list.</p></pre> </blockquote>
<p>On März 25th, 2015, 10:30 nachm. GMT, <b>Nick Shaforostoff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">please see \
https://projects.kde.org/projects/kde/kdesdk/lokalize/repository/revisions/master/entry/src/common/languagelistmodel.cpp \
for the ways to get a list of all languages (there is a KDE-way and Qt-way)</p></pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">So if I parse this correctly the KDE way is: <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">KConfig(QLatin1String("locale/kf5_all_languages"), KConfig::NoGlobals, \
QStandardPaths::GenericDataLocation).groupList()</code>? Should there be something in \
KI18n or is this sufficiently rare that we can just add "@deprecated use <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">KConfig(QLatin1String("locale/kf5_all_languages"), \
KConfig::NoGlobals, QStandardPaths::GenericDataLocation).groupList()</code> instead" \
to KLocale::languageList()?</p></pre> <br />
<p>- Alex</p>
<br />
<p>On März 25th, 2015, 9:17 nachm. GMT, Alex Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Plasma and Martin Koller.</div>
<div>By Alex Richardson.</div>
<p style="color: grey;"><i>Updated März 25, 2015, 9:17 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio-extras
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Port kio_man away from kdelibs4support</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">man view in kdevelop5 works</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Not \
sure about the <code style="text-rendering: inherit;color: #4444cc;padding: \
0;white-space: normal;margin: 0;line-height: \
inherit;">KLocale::global()->languageList();</code> -> <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">QLocale().uiLanguages();</code> change though so I would \
like some feedback.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(02ae89f2524324f758450ad368f64849e39b2f7d)</span></li>
<li>man/CMakeLists.txt <span style="color: \
grey">(cb4585a289d3f69b8a16429ce87bfce115d1cc27)</span></li>
<li>man/kio_man.cpp <span style="color: \
grey">(e8cf2d70c50c4c20adbb5a81a6213175d397b76e)</span></li>
<li>man/kmanpart.cpp <span style="color: \
grey">(3af7fc182806e8b89297e8de884ce611c827e881)</span></li>
<li>man/man2html.cpp <span style="color: \
grey">(3c493ba334bce890b450d7b11ab00c6e783708d4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123131/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0297143056861750898==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic