'Re: Review Request 122850: Fix regression in highlight of tabboxes'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 122850: Fix regression in highlight of tabboxes
From:       "Albert Astals Cid" <aacid () kde ! org>
Date:       2015-03-25 20:18:04
Message-ID: 20150325201804.17385.54390 () mimi ! kde ! org
[Download RAW message or body]

--===============0572562769375165977==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122850/
-----------------------------------------------------------

(Updated mar. 25, 2015, 8:18 p.m.)

Status
------

This change has been discarded.

Review request for Plasma.

Bugs: 341007
    http://bugs.kde.org/show_bug.cgi?id=341007

Repository: kdeplasma-addons

Description
-------

Don't animate the highlight when the holder is not visible

This way it's always at the correct place on first show.

Diffs
-----

  windowswitchers/thumbnails/contents/ui/main.qml f70b3fc 
  windowswitchers/informative/contents/ui/main.qml e50dee6 
  windowswitchers/text/contents/ui/main.qml 79f97c9 
  windowswitchers/compact/contents/ui/main.qml c90959d 
  windowswitchers/IconTabBox.qml 589d3da 

Diff: https://git.reviewboard.kde.org/r/122850/diff/

Testing
-------

Did an alt+tab, didn't get dizzy because the tab was going backwards when it should \
not.

Thanks,

Albert Astals Cid

--===============0572562769375165977==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122850/">https://git.reviewboard.kde.org/r/122850/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Albert Astals Cid.</div>

<p style="color: grey;"><i>Updated mar. 25, 2015, 8:18 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=341007">341007</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Don't animate the highlight when the holder is not \
visible</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This way it's always at the correct place on first \
show.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Did an alt+tab, didn't get dizzy because the tab was \
going backwards when it should not.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>windowswitchers/thumbnails/contents/ui/main.qml <span style="color: \
grey">(f70b3fc)</span></li>

 <li>windowswitchers/informative/contents/ui/main.qml <span style="color: \
grey">(e50dee6)</span></li>

 <li>windowswitchers/text/contents/ui/main.qml <span style="color: \
grey">(79f97c9)</span></li>

 <li>windowswitchers/compact/contents/ui/main.qml <span style="color: \
grey">(c90959d)</span></li>

 <li>windowswitchers/IconTabBox.qml <span style="color: grey">(589d3da)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122850/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0572562769375165977==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 