[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 121208: Port the KConfigXtEditor to KDevPlatform
From: "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date: 2015-03-24 23:59:17
Message-ID: 20150324235917.18119.17280 () mimi ! kde ! org
[Download RAW message or body]
--===============0951419976156119783==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121208/#review78034
-----------------------------------------------------------
Is it all in now? Maybe an updated screenshot would help?
Anyway, I trust your judgement if you want to ship this.
- Aleix Pol Gonzalez
On March 24, 2015, 8:38 p.m., Giorgos Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121208/
> -----------------------------------------------------------
>
> (Updated March 24, 2015, 8:38 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasmate
>
>
> Description
> -------
>
> This is a port of the KConfigXtEditor to KDevPlatform.
> The internals of the kconfigxteditor haven't changed.
>
>
> Diffs
> -----
>
> CMakeLists.txt edf3938
> Plasmate.cmake PRE-CREATION
> kconfigxteditor/CMakeLists.txt PRE-CREATION
> plasmate/CMakeLists.txt 6e07b30
> plasmate/editors/kconfigxt/kconfigxteditor.h
> plasmate/editors/kconfigxt/kconfigxteditor.cpp
> plasmate/editors/kconfigxt/kconfigxteditor.ui
> plasmate/editors/kconfigxt/kconfigxteditorpart.h 60a72af
> plasmate/editors/kconfigxt/kconfigxteditorpart.cpp 4bf252c
> plasmate/editors/kconfigxt/kconfigxtreader.h
> plasmate/editors/kconfigxt/kconfigxtreader.cpp
> plasmate/editors/kconfigxt/kconfigxtwriter.h
> plasmate/editors/kconfigxt/kconfigxtwriter.cpp
> plasmate/editors/kconfigxt/standalone/main.cpp
> plasmate/editors/kconfigxt/standalone/plasmakconfigxteditor.h 0287e04
> plasmate/editors/kconfigxt/standalone/plasmakconfigxteditor.cpp
> plasmate/plugins/CMakeLists.txt 186880f
> plasmate/plugins/kconfigxteditor/CMakeLists.txt PRE-CREATION
> plasmate/plugins/kconfigxteditor/kconfigxteditordocument.h PRE-CREATION
> plasmate/plugins/kconfigxteditor/kconfigxteditordocument.cpp PRE-CREATION
> plasmate/plugins/kconfigxteditor/kconfigxteditorview.cpp PRE-CREATION
> plasmate/plugins/kconfigxteditor/kdevkconfigxteditor.desktop.cmake PRE-CREATION
> plasmate/plugins/kconfigxteditor/kdevkconfigxteditorplugin.h PRE-CREATION
> plasmate/plugins/kconfigxteditor/kdevkconfigxteditorplugin.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/121208/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> kconfigxteditor in kdevelop
> https://git.reviewboard.kde.org/media/uploaded/files/2014/11/22/1e568048-4526-44cd-bc4c-04ded3236af0__kconfigxteditor.png
>
>
> Thanks,
>
> Giorgos Tsiapaliokas
>
>
--===============0951419976156119783==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121208/">https://git.reviewboard.kde.org/r/121208/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is it \
all in now? Maybe an updated screenshot would help?</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Anyway, I trust your judgement if you want to ship this.</p></pre> <br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On March 24th, 2015, 8:38 p.m. CET, Giorgos Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated March 24, 2015, 8:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasmate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is a port of the KConfigXtEditor to KDevPlatform. \
The internals of the kconfigxteditor haven't changed.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(edf3938)</span></li>
<li>Plasmate.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>kconfigxteditor/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasmate/CMakeLists.txt <span style="color: grey">(6e07b30)</span></li>
<li>plasmate/editors/kconfigxt/kconfigxteditor.h <span style="color: \
grey">()</span></li>
<li>plasmate/editors/kconfigxt/kconfigxteditor.cpp <span style="color: \
grey">()</span></li>
<li>plasmate/editors/kconfigxt/kconfigxteditor.ui <span style="color: \
grey">()</span></li>
<li>plasmate/editors/kconfigxt/kconfigxteditorpart.h <span style="color: \
grey">(60a72af)</span></li>
<li>plasmate/editors/kconfigxt/kconfigxteditorpart.cpp <span style="color: \
grey">(4bf252c)</span></li>
<li>plasmate/editors/kconfigxt/kconfigxtreader.h <span style="color: \
grey">()</span></li>
<li>plasmate/editors/kconfigxt/kconfigxtreader.cpp <span style="color: \
grey">()</span></li>
<li>plasmate/editors/kconfigxt/kconfigxtwriter.h <span style="color: \
grey">()</span></li>
<li>plasmate/editors/kconfigxt/kconfigxtwriter.cpp <span style="color: \
grey">()</span></li>
<li>plasmate/editors/kconfigxt/standalone/main.cpp <span style="color: \
grey">()</span></li>
<li>plasmate/editors/kconfigxt/standalone/plasmakconfigxteditor.h <span \
style="color: grey">(0287e04)</span></li>
<li>plasmate/editors/kconfigxt/standalone/plasmakconfigxteditor.cpp <span \
style="color: grey">()</span></li>
<li>plasmate/plugins/CMakeLists.txt <span style="color: grey">(186880f)</span></li>
<li>plasmate/plugins/kconfigxteditor/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/kconfigxteditor/kconfigxteditordocument.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/kconfigxteditor/kconfigxteditordocument.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/kconfigxteditor/kconfigxteditorview.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/kconfigxteditor/kdevkconfigxteditor.desktop.cmake <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/kconfigxteditor/kdevkconfigxteditorplugin.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasmate/plugins/kconfigxteditor/kdevkconfigxteditorplugin.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121208/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/11/22/1e568048-4526-44cd-bc4c-04ded3236af0__kconfigxteditor.png">kconfigxteditor \
in kdevelop</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0951419976156119783==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic