[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 122842: Allow selecting notifications position on screen
From: "Martin Klapetek" <martin.klapetek () gmail ! com>
Date: 2015-03-24 16:30:02
Message-ID: 20150324163002.18119.87451 () mimi ! kde ! org
[Download RAW message or body]
--===============2882111995061972095==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On March 24, 2015, 5:22 p.m., Kai Uwe Broulik wrote:
> > Nice!
> >
> > I'm not sure whether a global setting should be in the applet configuration but \
> > fair enough. The "Default" keeps the previous behavior where it sort-of follows \
> > your panel?
Yes.
> On March 24, 2015, 5:22 p.m., Kai Uwe Broulik wrote:
> > applets/notifications/package/contents/ui/configNotifications.qml, line 64
> > <https://git.reviewboard.kde.org/r/122842/diff/4/?file=356476#file356476line64>
> >
> > Emitting a signal inside a property binding looks wrong to me.
Well because the "screenPosition" property is not part of the regular config \
properties, something needs to tell the config dialog that things have changed and \
that it should enable the "Apply" button. Since the binding /requires/ a function, I \
thought why not?
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122842/#review78005
-----------------------------------------------------------
On March 24, 2015, 1:19 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122842/
> -----------------------------------------------------------
>
> (Updated March 24, 2015, 1:19 p.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 344841
> https://bugs.kde.org/show_bug.cgi?id=344841
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Allows to select each corner and top or bottom edges of the screen.
>
> The radio selection thing is currently a bit ugly and I'd like to ask for \
> suggestions on it (I originally wanted to add VDG here but there's no vdg group (?) \
> so I'll post in the forums).
>
> Diffs
> -----
>
> applets/notifications/CMakeLists.txt 113d731
> applets/notifications/lib/CMakeLists.txt PRE-CREATION
> applets/notifications/lib/notificationsapplet.h PRE-CREATION
> applets/notifications/lib/notificationsapplet.cpp PRE-CREATION
> applets/notifications/package/contents/ui/Notifications.qml 4312774
> applets/notifications/package/contents/ui/ScreenPositionSelector.qml PRE-CREATION
> applets/notifications/package/contents/ui/configNotifications.qml cda9ac9
> applets/notifications/package/metadata.desktop 333fa2c
> applets/notifications/plugin/notificationshelper.h ca0b63b
> applets/notifications/plugin/notificationshelper.cpp cd8a5a5
>
> Diff: https://git.reviewboard.kde.org/r/122842/diff/
>
>
> Testing
> -------
>
> All positions work
>
>
> File Attachments
> ----------------
>
> Screenshot
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/06/f80f9345-3d5f-49b4-83d7-16ecbfbc607a__notification_pos.png
> New Screenshot
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/11/e1fd3405-b008-4d6e-90c7-2000ab011008__notifications_config.png
>
>
> Thanks,
>
> Martin Klapetek
>
>
--===============2882111995061972095==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122842/">https://git.reviewboard.kde.org/r/122842/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 24th, 2015, 5:22 p.m. CET, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Nice!</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm not sure whether a \
global setting should be in the applet configuration but fair enough. The "Default" \
keeps the previous behavior where it sort-of follows your panel?</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Yes.</p></pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 24th, 2015, 5:22 p.m. CET, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/122842/diff/4/?file=356476#file356476line64" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/notifications/package/contents/ui/configNotifications.qml</a> \
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">64</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nx">plasmoid</span><span class="p">.</span><span \
class="nx">nativeInterface</span><span class="p">.</span><span \
class="nx">screenPosition</span> <span class="o">=</span> <span \
class="nx">Qt</span><span class="p">.</span><span class="nx">binding</span><span \
class="p">(</span><span class="kd">function</span><span class="p">()</span> <span \
class="p">{</span><span class="nx">configurationChanged</span><span \
class="p">();</span> <span class="k">return</span> <span \
class="nx">screenPositionSelector</span><span class="p">.</span><span \
class="nx">selectedPosition</span><span class="p">;</span> <span \
class="p">});</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Emitting a signal inside a property binding looks wrong to me.</p></pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well \
because the "screenPosition" property is not part of the regular config \
properties, something needs to tell the config dialog that things have changed and \
that it should enable the "Apply" button. Since the binding /requires/ a \
function, I thought why not?</pre> <br />
<p>- Martin</p>
<br />
<p>On March 24th, 2015, 1:19 p.m. CET, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated March 24, 2015, 1:19 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=344841">344841</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Allows to select each corner and top or bottom edges \
of the screen.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">The radio selection thing is currently \
a bit ugly and I'd like to ask for suggestions on it (I originally wanted to add VDG \
here but there's no vdg group (?) so I'll post in the forums).</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">All positions work</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/notifications/CMakeLists.txt <span style="color: \
grey">(113d731)</span></li>
<li>applets/notifications/lib/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/notifications/lib/notificationsapplet.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/notifications/lib/notificationsapplet.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/notifications/package/contents/ui/Notifications.qml <span style="color: \
grey">(4312774)</span></li>
<li>applets/notifications/package/contents/ui/ScreenPositionSelector.qml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>applets/notifications/package/contents/ui/configNotifications.qml <span \
style="color: grey">(cda9ac9)</span></li>
<li>applets/notifications/package/metadata.desktop <span style="color: \
grey">(333fa2c)</span></li>
<li>applets/notifications/plugin/notificationshelper.h <span style="color: \
grey">(ca0b63b)</span></li>
<li>applets/notifications/plugin/notificationshelper.cpp <span style="color: \
grey">(cd8a5a5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122842/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/03/06/f80f9345-3d5f-49b4-83d7-16ecbfbc607a__notification_pos.png">Screenshot</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/03/11/e1fd3405-b008-4d6e-90c7-2000ab011008__notifications_config.png">New \
Screenshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2882111995061972095==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic