[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123098: Don't show notification popup for persistent notifications when applet is
From: "Marco Martin" <notmart () gmail ! com>
Date: 2015-03-23 19:09:43
Message-ID: 20150323190943.18119.22057 () mimi ! kde ! org
[Download RAW message or body]
--===============6047363912455086025==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On March 23, 2015, 11:13 a.m., Martin Klapetek wrote:
> > This assumes that your systray is at the same position as the notification popup \
> > is, which is the default, true, but I'm a bit worried about cases where your \
> > systray is in a different position (and I do have that patch that allows you to \
> > select different popups position). Then it might be confusing if suddenly you \
> > don't see the popup (especially on bigger screens)?
>
> Marco Martin wrote:
> also plasmaoid.expanded may not be enough, since if the applet is in the systray, \
> some other systray applet may be open and cover it anyways i have half an idea \
> about hackishly going to search for the actual window and move the popups windows \
> if they'll intersect it (or maybe it could even try to intersect the notification \
> rect with all of the visible non desktop application qwindows...)
> Kai Uwe Broulik wrote:
> Hmm, is plasmoid.expanded really true when the systray popup is opened but the \
> plasmoid isn't the current? That would be weird, but I don't know...
> Intersecting with any window would lead to it "randomly" change position, also on a \
> laptop 95% of my windows are maximized anyway. But yeah, we can do better :)
no, when the systray popup is open and the notification plasmoid isn't the current \
expanded is false. that would be the problem no?
btw, with all windows i was only referring to plasmashell's windows, so pretty much \
just open popups, not other application's windows
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123098/#review77959
-----------------------------------------------------------
On March 22, 2015, 12:25 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123098/
> -----------------------------------------------------------
>
> (Updated March 22, 2015, 12:25 p.m.)
>
>
> Review request for Plasma and Martin Klapetek.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Persistent notifications are stored in the history. When you have currently opened \
> the plasmoid, you would see the notification right away, but it is then covered by \
> the popup of exactly the same notification. I tend to keep my tray opened when \
> copying lots of files and when the job finishes, I get this "odd" behavior.
>
> Diffs
> -----
>
> applets/notifications/package/contents/ui/Notifications.qml 4312774
>
> Diff: https://git.reviewboard.kde.org/r/123098/diff/
>
>
> Testing
> -------
>
> - knotificationdbustest with plasmoid closed yields 3+1 popups
> - knotificationdbustest with plasmoid opened yields no popups but the history fills \
> accordingly
> - notify-send results in a popup either way
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============6047363912455086025==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123098/">https://git.reviewboard.kde.org/r/123098/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 23rd, 2015, 11:13 a.m. UTC, <b>Martin \
Klapetek</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This assumes that your systray is at the same position \
as the notification popup is, which is the default, true, but I'm a bit worried about \
cases where your systray is in a different position (and I do have that patch that \
allows you to select different popups position). Then it might be confusing if \
suddenly you don't see the popup (especially on bigger screens)?</p></pre> \
</blockquote>
<p>On March 23rd, 2015, 12:15 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">also \
plasmaoid.expanded may not be enough, since if the applet is in the systray, some \
other systray applet may be open and cover it anyways i have half an idea about \
hackishly going to search for the actual window and move the popups windows if \
they'll intersect it (or maybe it could even try to intersect the notification rect \
with all of the visible non desktop application qwindows...)</p></pre> </blockquote>
<p>On March 23rd, 2015, 6:56 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hmm, \
is plasmoid.expanded really true when the systray popup is opened but the plasmoid \
isn't the current? That would be weird, but I don't know...</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Intersecting with any window would lead to it "randomly" change position, \
also on a laptop 95% of my windows are maximized anyway. But yeah, we can do better \
:)</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">no, \
when the systray popup is open and the notification plasmoid isn't the current \
expanded is false. that would be the problem no?
btw, with all windows i was only referring to plasmashell's windows, so pretty much \
just open popups, not other application's windows</p></pre> <br />
<p>- Marco</p>
<br />
<p>On March 22nd, 2015, 12:25 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Martin Klapetek.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated March 22, 2015, 12:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Persistent notifications are stored in the history. \
When you have currently opened the plasmoid, you would see the notification right \
away, but it is then covered by the popup of exactly the same notification. I tend to \
keep my tray opened when copying lots of files and when the job finishes, I get this \
"odd" behavior.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">knotificationdbustest \
with plasmoid closed yields 3+1 popups</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">knotificationdbustest \
with plasmoid opened yields no popups but the history fills accordingly</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">notify-send results in a popup either way</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/notifications/package/contents/ui/Notifications.qml <span style="color: \
grey">(4312774)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123098/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6047363912455086025==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic