[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 122921: Handle job error when showing job finished notification
From: "David Rosca" <nowrep () gmail ! com>
Date: 2015-03-22 11:41:43
Message-ID: 20150322114143.548.21099 () mimi ! kde ! org
[Download RAW message or body]
--===============0490705748917469206==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On March 22, 2015, 11:36 a.m., Kai Uwe Broulik wrote:
> > applets/notifications/package/contents/ui/Jobs.qml, line 69
> > <https://git.reviewboard.kde.org/r/122921/diff/1/?file=354553#file354553line69>
> >
> > Just noticed, shouldn't it rather be "Failed"?
> >
> > So you get "Copying: Failed" rather than "Error" because the job aborted?
"Failed" would probably be better, I wasn't really sure which word to choose.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122921/#review77905
-----------------------------------------------------------
On March 12, 2015, 5:46 p.m., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122921/
> -----------------------------------------------------------
>
> (Updated March 12, 2015, 5:46 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> When job finishes, the notifications applet shows a "%job_message%: Finished" \
> notification with action to open url (extracted from description). If the job \
> finishes with error, this notification still displays "Finished" and offers to open \
> url, but as the job finished with error, this url will most probably be invalid. \
> There is also no indication that the job actually finished with error.
> This patch checks for job error and in case of error, set notification summary to \
> "%job_message%: Error", body to error text and clears the actions (no open url).
> It only works with jobs that actually sets the error text (KJob::setErrorText), \
> because KJob::error is not exposed in dataengine.
>
> Diffs
> -----
>
> applets/notifications/package/contents/ui/Jobs.qml ee3ec5b
>
> Diff: https://git.reviewboard.kde.org/r/122921/diff/
>
>
> Testing
> -------
>
> Error in job is now detected, displayed in notification and there is no "open url" \
> action.
>
> File Attachments
> ----------------
>
> error-notification
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/12/a7f43698-8c8d-4ad3-aa03-5b527fcdc2d9__job-notification.png
>
>
> Thanks,
>
> David Rosca
>
>
--===============0490705748917469206==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122921/">https://git.reviewboard.kde.org/r/122921/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 22nd, 2015, 11:36 a.m. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/122921/diff/1/?file=354553#file354553line69" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/notifications/package/contents/ui/Jobs.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">69</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="nx">summary</span> <span class="o">=</span> <span \
class="nx">infoMessage</span> <span class="o">?</span> <span \
class="nx">i18nc</span><span class="p">(</span><span class="s2">"the job, which \
can be anything, finished with error"</span><span class="p">,</span> <span \
class="s2">"%1: Error"</span><span class="p">,</span> <span \
class="nx">infoMessage</span><span class="p">)</span> <span class="o">:</span> <span \
class="nx">i18n</span><span class="p">(</span><span class="s2">"Job \
Error"</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Just \
noticed, shouldn't it rather be "Failed"?</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">So you get "Copying: \
Failed" rather than "Error" because the job aborted?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">"Failed" would probably be better, I wasn't really sure which word to \
choose.</p></pre> <br />
<p>- David</p>
<br />
<p>On March 12th, 2015, 5:46 p.m. UTC, David Rosca wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Rosca.</div>
<p style="color: grey;"><i>Updated March 12, 2015, 5:46 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When job finishes, the notifications applet shows a \
"%job_message%: Finished" notification with action to open url (extracted from \
description). If the job finishes with error, this notification still displays \
"Finished" and offers to open url, but as the job finished with error, this url will \
most probably be invalid. There is also no indication that the job actually finished \
with error.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch checks for job error and in case of error, \
set notification summary to "%job_message%: Error", body to error text and clears the \
actions (no open url).</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">It only works with jobs that actually \
sets the error text (KJob::setErrorText), because KJob::error is not exposed in \
dataengine.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Error in job is now detected, displayed in \
notification and there is no "open url" action.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/notifications/package/contents/ui/Jobs.qml <span style="color: \
grey">(ee3ec5b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122921/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/03/12/a7f43698-8c8d-4ad3-aa03-5b527fcdc2d9__job-notification.png">error-notification</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0490705748917469206==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic