[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 122673: Make Svg, FrameSvg work qith QT_DEVICE_PIXELRATIO
From: "Marco Martin" <notmart () gmail ! com>
Date: 2015-03-06 14:34:33
Message-ID: 20150306143433.22963.21427 () probe ! kde ! org
[Download RAW message or body]
--===============3059149452662100500==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122673/
-----------------------------------------------------------
(Updated March 6, 2015, 2:34 p.m.)
Review request for Plasma.
Repository: plasma-framework
Description
-------
(still in progress but here for feedback)
when QT_DEVICE_PIXELRATIO is something different from 1, the pixmaps generated by Svg \
will be scaled up to give a proper texture.
This is complementary but not replacing our current approach:
the pixelratio that can be accessed by units is now in relation to the qt pixel \
ratio, spacings are also adjusted accordingly (therefore, spaces and sizes won't need \
an integer value like pixelratio)
svg introduces also a scaleFactor property (that is pretty much like its old \
pixelRatio) basically, scalefactor, will scale both the textures *and* all the \
reported sizes, (old method) pixelratio just scales textures without altering \
measures (like qt pixelratio likes) they are now both used and combined, so a) we can \
have this working before supporting officially qt pixelratio when will be good enough \
but b) keeping the old mwthod working for the time being c) by using both at the sae \
time we can at least scale sizes of values != from integers, for screens that are too \
dense for 1 and not enough for 2
Diffs (updated)
-----
src/declarativeimports/core/framesvgitem.cpp dae8a4f
src/declarativeimports/core/iconitem.cpp 03f40c4
src/declarativeimports/core/svgitem.cpp 570c1c3
src/declarativeimports/core/units.h 6c038ba
src/declarativeimports/core/units.cpp a740145
src/plasma/framesvg.cpp 1bb3510
src/plasma/private/svg_p.h a31d0ac
src/plasma/svg.h 0bcbd7a
src/plasma/svg.cpp 0a0db5e
Diff: https://git.reviewboard.kde.org/r/122673/diff/
Testing
-------
Thanks,
Marco Martin
--===============3059149452662100500==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122673/">https://git.reviewboard.kde.org/r/122673/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated March 6, 2015, 2:34 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">(still in progress but here for feedback) when \
QT_DEVICE_PIXELRATIO is something different from 1, the pixmaps generated by Svg will \
be scaled up to give a proper texture.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This is complementary \
but not replacing our current approach: the pixelratio that can be accessed by units \
is now in relation to the qt pixel ratio, spacings are also adjusted accordingly \
(therefore, spaces and sizes won't need an integer value like pixelratio)</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">svg introduces also a scaleFactor property (that is pretty much like its \
old pixelRatio) basically, scalefactor, will scale both the textures <em \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">and</em> all the reported sizes, (old method) pixelratio just scales \
textures without altering measures (like qt pixelratio likes) they are now both used \
and combined, so a) we can have this working before supporting officially qt \
pixelratio when will be good enough but b) keeping the old mwthod working for the \
time being c) by using both at the sae time we can at least scale sizes of values != \
from integers, for screens that are too dense for 1 and not enough for 2</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/core/framesvgitem.cpp <span style="color: \
grey">(dae8a4f)</span></li>
<li>src/declarativeimports/core/iconitem.cpp <span style="color: \
grey">(03f40c4)</span></li>
<li>src/declarativeimports/core/svgitem.cpp <span style="color: \
grey">(570c1c3)</span></li>
<li>src/declarativeimports/core/units.h <span style="color: \
grey">(6c038ba)</span></li>
<li>src/declarativeimports/core/units.cpp <span style="color: \
grey">(a740145)</span></li>
<li>src/plasma/framesvg.cpp <span style="color: grey">(1bb3510)</span></li>
<li>src/plasma/private/svg_p.h <span style="color: grey">(a31d0ac)</span></li>
<li>src/plasma/svg.h <span style="color: grey">(0bcbd7a)</span></li>
<li>src/plasma/svg.cpp <span style="color: grey">(0a0db5e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122673/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3059149452662100500==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic