[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 122736: [dataengines/geolocation] Use wifi data if available
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2015-03-04 13:25:54
Message-ID: 20150304132554.6755.56801 () probe ! kde ! org
[Download RAW message or body]
--===============2142707789489292702==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Feb. 27, 2015, 11:48 a.m., Martin Klapetek wrote:
> > Can this be configured? I for sure don't want to be sending all my surroundings \
> > "somewhere"
>
> Martin Gräßlin wrote:
> Yes it probably even has to be configured. I think we need to present the "privacy \
> contract" of the service and have the user acknowledge it.
started a thread on VDG for a privacy center: \
https://forum.kde.org/viewtopic.php?f=285&t=125260
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122736/#review76711
-----------------------------------------------------------
On March 4, 2015, 2 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122736/
> -----------------------------------------------------------
>
> (Updated March 4, 2015, 2 p.m.)
>
>
> Review request for Plasma, Jan Grulich and Lukáš Tinkl.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Adds a dependency to NetworkManager and queries the available wifi
> access points to include in the request to the location service.
>
>
> Diffs
> -----
>
> CMakeLists.txt 8b1529e6aea7e10f89696a495c2791b6383d9489
> dataengines/geolocation/CMakeLists.txt efdcd14940b47a64b4e70dce69bdeeffdc6873f5
> dataengines/geolocation/geolocation.h fcc95086b97b6c96c0ab9bce3cac703d96d0b43e
> dataengines/geolocation/geolocation.cpp e02060e157a29902e594310102555096bd619e2e
> dataengines/geolocation/location_ip.cpp 3a13dc3018bff482c48098e1827f31c5fa3184cc
>
> Diff: https://git.reviewboard.kde.org/r/122736/diff/
>
>
> Testing
> -------
>
> Tested with my available networks and checked position on openstreetmaps. Basically \
> it even put me in the right room of the building I'm in.
>
> Thanks,
>
> Martin Gräßlin
>
>
--===============2142707789489292702==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122736/">https://git.reviewboard.kde.org/r/122736/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 27th, 2015, 11:48 a.m. CET, <b>Martin \
Klapetek</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Can this be configured? I for sure don't want to be \
sending all my surroundings "somewhere"</p></pre> </blockquote>
<p>On February 27th, 2015, 1:32 p.m. CET, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes \
it probably even has to be configured. I think we need to present the "privacy \
contract" of the service and have the user acknowledge it.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">started a thread on VDG for a privacy center: \
https://forum.kde.org/viewtopic.php?f=285&t=125260</p></pre> <br />
<p>- Martin</p>
<br />
<p>On March 4th, 2015, 2 p.m. CET, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, Jan Grulich and Lukáš Tinkl.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated March 4, 2015, 2 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adds a dependency to NetworkManager and queries the available wifi \
access points to include in the request to the location service.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested with my available networks and checked position \
on openstreetmaps. Basically it even put me in the right room of the building I'm \
in.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(8b1529e6aea7e10f89696a495c2791b6383d9489)</span></li>
<li>dataengines/geolocation/CMakeLists.txt <span style="color: \
grey">(efdcd14940b47a64b4e70dce69bdeeffdc6873f5)</span></li>
<li>dataengines/geolocation/geolocation.h <span style="color: \
grey">(fcc95086b97b6c96c0ab9bce3cac703d96d0b43e)</span></li>
<li>dataengines/geolocation/geolocation.cpp <span style="color: \
grey">(e02060e157a29902e594310102555096bd619e2e)</span></li>
<li>dataengines/geolocation/location_ip.cpp <span style="color: \
grey">(3a13dc3018bff482c48098e1827f31c5fa3184cc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122736/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2142707789489292702==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic