'Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons
From:       Sebastian_Kügler <sebas () kde ! org>
Date:       2015-03-03 2:43:20
Message-ID: 20150303024320.6755.89681 () probe ! kde ! org
[Download RAW message or body]

--===============3962713820624651564==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122239/#review76937
-----------------------------------------------------------

Ship it!

Ship It!

- Sebastian Kügler

On Jan. 24, 2015, 11:54 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122239/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2015, 11:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> Since there are already like 10 copies of the ProcessRunner for all kinds of \
> plasmoids wanting to open a KCM, this adds a KCMShell.open("foo") and \
> KCMShell.open(["foo", "bar", "baz"]) singleton. 
> 
> Diffs
> -----
> 
> src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 65e28ff 
> src/qmlcontrols/kquickcontrolsaddons/kcmshell.h PRE-CREATION 
> src/qmlcontrols/kquickcontrolsaddons/kcmshell.cpp PRE-CREATION 
> src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp 289f1ed 
> 
> Diff: https://git.reviewboard.kde.org/r/122239/diff/
> 
> 
> Testing
> -------
> 
> Works. Dunno if the name causes clashes or this is the right place to put it.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
> 

--===============3962713820624651564==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122239/">https://git.reviewboard.kde.org/r/122239/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Sebastian Kügler</p>

<br />
<p>On January 24th, 2015, 11:54 p.m. UTC, Kai Uwe Broulik wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Jan. 24, 2015, 11:54 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeclarative
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Since there are already like 10 copies of the \
ProcessRunner for all kinds of plasmoids wanting to open a KCM, this adds a \
KCMShell.open("foo") and KCMShell.open(["foo", "bar", "baz"]) singleton.</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works. Dunno if the name causes clashes or this is the \
right place to put it.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt <span style="color: \
grey">(65e28ff)</span></li>

 <li>src/qmlcontrols/kquickcontrolsaddons/kcmshell.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/qmlcontrols/kquickcontrolsaddons/kcmshell.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp <span \
style="color: grey">(289f1ed)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122239/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3962713820624651564==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 