[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 122742: Add a combo box to select QT_DEVICE_PIXEL_RATIO
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2015-03-03 0:41:15
Message-ID: 20150303004115.6755.94981 () probe ! kde ! org
[Download RAW message or body]
--===============4938680033469122784==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On March 2, 2015, 6:26 p.m., Martin Klapetek wrote:
> > File Attachment: screenshot.png - screenshot.png
> > <https://git.reviewboard.kde.org/r/122742/#fcomment368>
> >
> > I'd suggest FormLayout/GridLayout so these are aligned
I'd suggest the same. Perhaps we can even move the message about the setting taking \
effect next to the combo?
- Sebastian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122742/#review76917
-----------------------------------------------------------
On March 2, 2015, 6:16 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122742/
> -----------------------------------------------------------
>
> (Updated March 2, 2015, 6:16 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: kscreen
>
>
> Description
> -------
>
> Add a combo box to select QT_DEVICE_PIXEL_RATIO
>
> Probably not worth merging just yet, given some other parts are broken...but it's a \
> step forwards.
>
> Diffs
> -----
>
> CMakeLists.txt 6f1769a
> kcm/src/CMakeLists.txt 8c693b5
> kcm/src/kcm_kscreen.cpp b9f3596
> kcm/src/widget.h 88d6407
> kcm/src/widget.cpp 9ff8af6
>
> Diff: https://git.reviewboard.kde.org/r/122742/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> screenshot.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/02/be44beec-aba8-4551-ab55-a5a04febd8fe__screenshot.png
>
>
> Thanks,
>
> David Edmundson
>
>
--===============4938680033469122784==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122742/">https://git.reviewboard.kde.org/r/122742/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 2nd, 2015, 6:26 p.m. UTC, <b>Martin \
Klapetek</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding: 0 0 0 1em;">
<br style="display: none;" />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid \
#c0c0c0; margin-bottom: 10px"> <tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122742/file/1927/" style="color: \
black; font-weight: bold; font-size: 9pt;">screenshot.png</a>
<p>screenshot.png</p>
</td>
</tr>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'd suggest \
FormLayout/GridLayout so these are aligned</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I'd suggest the same. Perhaps we can even move the message about the \
setting taking effect next to the combo?</p></pre> <br />
<p>- Sebastian</p>
<br />
<p>On March 2nd, 2015, 6:16 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated March 2, 2015, 6:16 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kscreen
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Add a combo box to select QT_DEVICE_PIXEL_RATIO</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Probably not worth merging just yet, given some other parts are \
broken...but it's a step forwards.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(6f1769a)</span></li>
<li>kcm/src/CMakeLists.txt <span style="color: grey">(8c693b5)</span></li>
<li>kcm/src/kcm_kscreen.cpp <span style="color: grey">(b9f3596)</span></li>
<li>kcm/src/widget.h <span style="color: grey">(88d6407)</span></li>
<li>kcm/src/widget.cpp <span style="color: grey">(9ff8af6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122742/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/03/02/be44beec-aba8-4551-ab55-a5a04febd8fe__screenshot.png">screenshot.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4938680033469122784==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic