[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 122742: Add a combo box to select QT_DEVICE_PIXEL_RATIO
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2015-03-02 18:16:55
Message-ID: 20150302181655.6755.65576 () probe ! kde ! org
[Download RAW message or body]
--===============2693442843014938318==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122742/
-----------------------------------------------------------
(Updated March 2, 2015, 6:16 p.m.)
Review request for Plasma.
Changes
-------
add screenie.
I'm not entirely happy with it, so suggestions welcome.
Repository: kscreen
Description
-------
Add a combo box to select QT_DEVICE_PIXEL_RATIO
Probably not worth merging just yet, given some other parts are broken...but it's a \
step forwards.
Diffs
-----
CMakeLists.txt 6f1769a
kcm/src/CMakeLists.txt 8c693b5
kcm/src/kcm_kscreen.cpp b9f3596
kcm/src/widget.h 88d6407
kcm/src/widget.cpp 9ff8af6
Diff: https://git.reviewboard.kde.org/r/122742/diff/
Testing
-------
File Attachments (updated)
----------------
screenshot.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/03/02/be44beec-aba8-4551-ab55-a5a04febd8fe__screenshot.png
Thanks,
David Edmundson
--===============2693442843014938318==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122742/">https://git.reviewboard.kde.org/r/122742/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated March 2, 2015, 6:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">add screenie.
I'm not entirely happy with it, so suggestions welcome.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kscreen
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Add a combo box to select QT_DEVICE_PIXEL_RATIO</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Probably not worth merging just yet, given some other parts are \
broken...but it's a step forwards.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(6f1769a)</span></li>
<li>kcm/src/CMakeLists.txt <span style="color: grey">(8c693b5)</span></li>
<li>kcm/src/kcm_kscreen.cpp <span style="color: grey">(b9f3596)</span></li>
<li>kcm/src/widget.h <span style="color: grey">(88d6407)</span></li>
<li>kcm/src/widget.cpp <span style="color: grey">(9ff8af6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122742/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
(updated)</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/03/02/be44beec-aba8-4551-ab55-a5a04febd8fe__screenshot.png">screenshot.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2693442843014938318==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic