'Review Request 122766: Don't use a possibly non-existent property "animationsEnabled".'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request 122766: Don't use a possibly non-existent property "animationsEnabled".
From:       "Elias Probst" <mail () eliasprobst ! eu>
Date:       2015-02-28 22:47:04
Message-ID: 20150228224704.12883.35570 () probe ! kde ! org
[Download RAW message or body]

--===============8551092526503610083==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122766/
-----------------------------------------------------------

Review request for Plasma.

Repository: plasma-desktop

Description
-------

**Commit MSG:**
```
This prevents the following error message on plasmashell startup:

default unknown:
file:///usr/share/plasma/plasmoids/org.kde.panel/contents/ui/main.qml:448:
Error: Cannot assign to non-existent property "animationsEnabled"
```

As I'm not sure what the hackery in the Timer element actually does, somebody needs \
to review this before I go and commit it.

Diffs
-----

  containments/panel/contents/ui/main.qml 2772bfe934ca7a80e58953c15ed76d99c358bbbb 

Diff: https://git.reviewboard.kde.org/r/122766/diff/

Testing
-------

- error message on plasmashell startup is gone
- animations in panel still work

Thanks,

Elias Probst

--===============8551092526503610083==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122766/">https://git.reviewboard.kde.org/r/122766/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Elias Probst.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><strong style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Commit MSG:</strong></p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><div class="codehilite" style="background: \
#f8f8f8"><pre style="line-height: 125%">This prevents the following error message on \
plasmashell startup<span style="color: #666666">:</span>

<span style="color: #008000; font-weight: bold">default</span> unknown<span \
style="color: #666666">:</span> <span style="color: #A0A000">file:</span><span \
style="color: #408080; font-style: \
italic">///usr/share/plasma/plasmoids/org.kde.panel/contents/ui/main.qml:448:</span> \
<span style="color: #A0A000">Error:</span> Cannot assign to non<span style="color: \
#666666">-</span>existent property <span style="color: \
#BA2121">&quot;animationsEnabled&quot;</span> </pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">As I'm not sure what the hackery in the Timer element \
actually does, somebody needs to review this before I go and commit it.</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">error message on \
plasmashell startup is gone</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">animations in panel \
still work</li> </ul></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>containments/panel/contents/ui/main.qml <span style="color: \
grey">(2772bfe934ca7a80e58953c15ed76d99c358bbbb)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122766/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8551092526503610083==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 