'Re: Review Request 122745: Monitor baloo for new media files'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 122745: Monitor baloo for new media files
From:       "Bhushan Shah" <bhush94 () gmail ! com>
Date:       2015-02-28 6:46:13
Message-ID: 20150228064613.12884.64207 () probe ! kde ! org
[Download RAW message or body]

--===============4064956042470128612==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122745/
-----------------------------------------------------------

(Updated Feb. 28, 2015, 6:46 a.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Vishesh Handa.

Repository: plasma-mediacenter

Description
-------

This is uses the dbus signal provided by baloo, checks them mimetype of that file and \
passes that to related searchresulthandler

Bonus point of this is in case properties of any files changes we also get updates.

Diffs
-----

  mediasources/baloosearch/CMakeLists.txt 9bec5fd6c5af585b8faa53d5440878bf0dcf6566 
  mediasources/baloosearch/audiosearchresulthandler.h \
3efb4bf1efc337a0a293bc1c391707302a76172c   \
mediasources/baloosearch/audiosearchresulthandler.cpp \
0c9d93b1988af62836f9c547707395810da311a2   \
mediasources/baloosearch/baloosearchmediasource.h \
e0289026e2cbf9c7e145f66b057b7ae6287b8e48   \
mediasources/baloosearch/baloosearchmediasource.cpp \
b90e9c03e352d1fd6962fbb28de9b8714e866fde   \
mediasources/baloosearch/imagesearchresulthandler.h \
72a2cb30617b91b92e9176688e21d63504876eb1   \
mediasources/baloosearch/imagesearchresulthandler.cpp \
6df3a2c11092422a18b00bb668498dc1b5fcbc2e   \
mediasources/baloosearch/searchresulthandler.h \
176327409fa9acd92d21a69e2a91f035d9140f51   \
mediasources/baloosearch/videosearchresulthandler.h \
00d048cc0bfa44ae323afd531c7b41a3bcbcd528   \
mediasources/baloosearch/videosearchresulthandler.cpp \
f1439e735be43be68d0b4625019493f9249ae1e5 

Diff: https://git.reviewboard.kde.org/r/122745/diff/

Testing
-------

Moved some files from External drive to $HOME, they got added to medialibrary, \
verified by debug messages for images and manually for music files

Thanks,

Bhushan Shah

--===============4064956042470128612==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122745/">https://git.reviewboard.kde.org/r/122745/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Vishesh \
Handa.</div> <div>By Bhushan Shah.</div>

<p style="color: grey;"><i>Updated Feb. 28, 2015, 6:46 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is uses the dbus signal provided by baloo, checks \
them mimetype of that file and passes that to related searchresulthandler</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Bonus point of this is in case properties of any files changes we also get \
updates.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Moved some files from External drive to $HOME, they \
got added to medialibrary, verified by debug messages for images and manually for \
music files</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>mediasources/baloosearch/CMakeLists.txt <span style="color: \
grey">(9bec5fd6c5af585b8faa53d5440878bf0dcf6566)</span></li>

 <li>mediasources/baloosearch/audiosearchresulthandler.h <span style="color: \
grey">(3efb4bf1efc337a0a293bc1c391707302a76172c)</span></li>

 <li>mediasources/baloosearch/audiosearchresulthandler.cpp <span style="color: \
grey">(0c9d93b1988af62836f9c547707395810da311a2)</span></li>

 <li>mediasources/baloosearch/baloosearchmediasource.h <span style="color: \
grey">(e0289026e2cbf9c7e145f66b057b7ae6287b8e48)</span></li>

 <li>mediasources/baloosearch/baloosearchmediasource.cpp <span style="color: \
grey">(b90e9c03e352d1fd6962fbb28de9b8714e866fde)</span></li>

 <li>mediasources/baloosearch/imagesearchresulthandler.h <span style="color: \
grey">(72a2cb30617b91b92e9176688e21d63504876eb1)</span></li>

 <li>mediasources/baloosearch/imagesearchresulthandler.cpp <span style="color: \
grey">(6df3a2c11092422a18b00bb668498dc1b5fcbc2e)</span></li>

 <li>mediasources/baloosearch/searchresulthandler.h <span style="color: \
grey">(176327409fa9acd92d21a69e2a91f035d9140f51)</span></li>

 <li>mediasources/baloosearch/videosearchresulthandler.h <span style="color: \
grey">(00d048cc0bfa44ae323afd531c7b41a3bcbcd528)</span></li>

 <li>mediasources/baloosearch/videosearchresulthandler.cpp <span style="color: \
grey">(f1439e735be43be68d0b4625019493f9249ae1e5)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122745/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4064956042470128612==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 