'Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2015-02-27 18:40:26
Message-ID: 20150227184026.12883.25815 () probe ! kde ! org
[Download RAW message or body]

--===============6036320400799620083==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122400/#review76738
-----------------------------------------------------------

bump, or I'm going to push it anyway.

- David Edmundson

On Feb. 11, 2015, 2:51 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122400/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2015, 2:51 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> The current time setting helper is incredibly broken.
> 
> It manually tries to run a range of NTP utilities, all of which are
> deprecated.
> 
> We can just call timedated directly and cut out the middleman as it has
> uses polkit anyway.
> 
> This is currently an optional dependency, and the original helper still
> exists. It makes the code messy, but we have users to support for now.
> 
> Finding timedated is an cmake option rather than querying for systemd
> libs to make it easier for those deploying shims, such as BSD.
> 
> 
> (code is in two commits, first abstracting the saving from the dtime class; then \
> adding in the second save mechanism)  
> 
> Diffs
> -----
> 
> kcms/dateandtime/CMakeLists.txt 4a987ae 
> kcms/dateandtime/dateandtime.ui c073b5e 
> kcms/dateandtime/dtime.h 1a90698 
> kcms/dateandtime/dtime.cpp 482e483 
> kcms/dateandtime/main.h c1e5234 
> kcms/dateandtime/main.cpp 0041a9d 
> kcms/dateandtime/timedated1.xml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122400/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
> 

--===============6036320400799620083==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122400/">https://git.reviewboard.kde.org/r/122400/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">bump, \
or I'm going to push it anyway.</p></pre>  <br />

<p>- David Edmundson</p>

<br />
<p>On February 11th, 2015, 2:51 p.m. UTC, David Edmundson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated Feb. 11, 2015, 2:51 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The current time setting helper is incredibly \
broken.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It manually tries to run a range of NTP utilities, all \
of which are deprecated.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">We can just call timedated directly and cut out the \
middleman as it has uses polkit anyway.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is currently an optional dependency, and the \
original helper still exists. It makes the code messy, but we have users to support \
for now.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Finding timedated is an cmake option rather than \
querying for systemd libs to make it easier for those deploying shims, such as \
BSD.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">(code is in two commits, first abstracting the saving \
from the dtime class; then adding in the second save mechanism) </p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kcms/dateandtime/CMakeLists.txt <span style="color: grey">(4a987ae)</span></li>

 <li>kcms/dateandtime/dateandtime.ui <span style="color: grey">(c073b5e)</span></li>

 <li>kcms/dateandtime/dtime.h <span style="color: grey">(1a90698)</span></li>

 <li>kcms/dateandtime/dtime.cpp <span style="color: grey">(482e483)</span></li>

 <li>kcms/dateandtime/main.h <span style="color: grey">(c1e5234)</span></li>

 <li>kcms/dateandtime/main.cpp <span style="color: grey">(0041a9d)</span></li>

 <li>kcms/dateandtime/timedated1.xml <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122400/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6036320400799620083==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 