From kde-panel-devel Fri Feb 27 16:39:15 2015 From: =?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?= Date: Fri, 27 Feb 2015 16:39:15 +0000 To: kde-panel-devel Subject: Re: Review Request 122742: Add a combo box to select QT_DEVICE_PIXEL_RATIO Message-Id: <20150227163915.12883.24334 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=142505517232488 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4712899166821342606==" --===============4712899166821342606== Content-Type: multipart/alternative; boundary="===============1046580004070368186==" --===============1046580004070368186== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122742/#review76732 ----------------------------------------------------------- a general suggestion: use KConfigXT for wrapping the config value. - Martin Gräßlin On Feb. 27, 2015, 5:13 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122742/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2015, 5:13 p.m.) > > > Review request for Plasma. > > > Repository: kscreen > > > Description > ------- > > Add a combo box to select QT_DEVICE_PIXEL_RATIO > > Probably not worth merging just yet, given some other parts are broken...but it's a step forwards. > > > Diffs > ----- > > CMakeLists.txt 6f1769a > kcm/src/CMakeLists.txt 8c693b5 > kcm/src/kcm_kscreen.cpp b9f3596 > kcm/src/widget.h 88d6407 > kcm/src/widget.cpp 9ff8af6 > > Diff: https://git.reviewboard.kde.org/r/122742/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > > --===============1046580004070368186== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122742/

a general suggestion: use KConfigXT for wrapping the config value.

- Martin Gräßlin

On February 27th, 2015, 5:13 p.m. CET, David Edmundson wrote:

Review request for Plasma.

By David Edmundson.

Updated Feb. 27, 2015, 5:13 p.m.

Repository: kscreen

Description

Add a combo box to select QT_DEVICE_PIXEL_RATIO

Probably not worth merging just yet, given some other parts are broken...but it's a step forwards.

Diffs

CMakeLists.txt (6f1769a)
kcm/src/CMakeLists.txt (8c693b5)
kcm/src/kcm_kscreen.cpp (b9f3596)
kcm/src/widget.h (88d6407)
kcm/src/widget.cpp (9ff8af6)

View Diff

--===============1046580004070368186==-- --===============4712899166821342606== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============4712899166821342606==--