[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 122738: Make sure the OSD is not bigger than 1/3 of the screen
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2015-02-27 12:40:18
Message-ID: 20150227124018.12883.69326 () probe ! kde ! org
[Download RAW message or body]
--===============6575304956400653741==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122738/#review76722
-----------------------------------------------------------
lookandfeel/contents/osd/OsdItem.qml
<https://git.reviewboard.kde.org/r/122738/#comment52830>
Math.min()?
- Sebastian Kügler
On Feb. 27, 2015, 11:45 a.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122738/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2015, 11:45 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> So that it does not cover your whole screen on smaller displays with higher DPIs
>
>
> Diffs
> -----
>
> lookandfeel/contents/osd/OsdItem.qml f4a5580
>
> Diff: https://git.reviewboard.kde.org/r/122738/diff/
>
>
> Testing
> -------
>
> Works but I'm unsure on how this behaves on multiscreen, if someone could test \
> that'd be great.
>
> Thanks,
>
> Martin Klapetek
>
>
--===============6575304956400653741==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122738/">https://git.reviewboard.kde.org/r/122738/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/122738/diff/1/?file=352041#file352041line26" \
style="color: black; font-weight: bold; text-decoration: \
underline;">lookandfeel/contents/osd/OsdItem.qml</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">25</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">height:</span> <span class="nx">units</span><span class="p">.</span><span \
class="nx">gridUnit</span> <span class="o">*</span> <span \
class="mi">15</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">26</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">height:</span> <span \
class="nx">units</span><span class="p">.</span><span class="nx">gridUnit</span> <span \
class="o">*</span> <span class="mi">15</span><span class="hl"> </span><span \
class="o"><span class="hl">></span></span><span class="hl"> </span><span \
class="p"><span class="hl">(</span></span><span class="nx"><span \
class="hl">Screen</span></span><span class="p"><span class="hl">.</span></span><span \
class="nx"><span class="hl">desktopAvailableHeight</span></span><span class="hl"> \
</span><span class="o"><span class="hl">/</span></span><span class="hl"> </span><span \
class="mi"><span class="hl">3</span></span><span class="p"><span \
class="hl">)</span></span><span class="hl"> </span><span class="o"><span \
class="hl">?</span></span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Math.min()?</p></pre> </div>
</div>
<br />
<p>- Sebastian Kügler</p>
<br />
<p>On February 27th, 2015, 11:45 a.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Feb. 27, 2015, 11:45 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">So that it does not cover your whole screen on smaller \
displays with higher DPIs</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works but I'm unsure on how this behaves on \
multiscreen, if someone could test that'd be great.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lookandfeel/contents/osd/OsdItem.qml <span style="color: \
grey">(f4a5580)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122738/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6575304956400653741==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic