[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 122450: Do not set global shortcuts for the Media keys
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2015-02-27 12:34:47
Message-ID: 20150227123447.12884.96222 () probe ! kde ! org
[Download RAW message or body]
--===============6382908233331439430==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Feb. 27, 2015, 1:13 p.m., Myriam Schweingruber wrote:
> > I didn't give a ship it yet as I want to get Amarok 2.9 beta out first.
I don't get this argument. It would be very important if we get this change into the \
beta and best also in stable releases.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122450/#review76713
-----------------------------------------------------------
On Feb. 6, 2015, 9:06 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122450/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2015, 9:06 a.m.)
>
>
> Review request for Amarok and Plasma.
>
>
> Repository: amarok
>
>
> Description
> -------
>
> Amarok used to grab the keys for:
> * Qt::Key_MediaPlay
> * Qt::Key_MediaStop
> * Qt::Key_MediaNext
> * Qt::Key_MediaPrevious
>
> As those are global shortcuts they are taken away from any other
> application when Amarok is running. E.g. if I watch a movie in VLC
> and press the media play button (which VLC handles) Amarok will start
> playback if it's running. If Amarok is not running, VLC will pause
> the playback. This shows that a multi-media application should not
> globally grab these keys.
>
> In addition we just introduced a change [1] in plasma-workspace for the
> Plasma/5.3 release to grab these shortcuts and bind them to the
> mpris2 dataengine. Now the mpris2 engine handles those shortcuts and
> delegates to the currently active application.
>
> [1] http://commits.kde.org/plasma-workspace/409fdfab03e7a0b5a61e7796e1fba85b143eab3b
>
>
> Diffs
> -----
>
> src/ActionClasses.cpp 3f6a63e073f76db8ec05daf531dd2d828d3f9c0d
> src/MainWindow.cpp 484f4251f8911f1c4e63f61ae17efd7b17b5c4e6
>
> Diff: https://git.reviewboard.kde.org/r/122450/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
--===============6382908233331439430==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122450/">https://git.reviewboard.kde.org/r/122450/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 27th, 2015, 1:13 p.m. CET, <b>Myriam \
Schweingruber</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I didn't give a ship it yet as I want to get Amarok \
2.9 beta out first.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
don't get this argument. It would be very important if we get this change into the \
beta and best also in stable releases.</p></pre> <br />
<p>- Martin</p>
<br />
<p>On February 6th, 2015, 9:06 a.m. CET, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Amarok and Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Feb. 6, 2015, 9:06 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Amarok used to grab the keys for:
* Qt::Key_MediaPlay
* Qt::Key_MediaStop
* Qt::Key_MediaNext
* Qt::Key_MediaPrevious
As those are global shortcuts they are taken away from any other
application when Amarok is running. E.g. if I watch a movie in VLC
and press the media play button (which VLC handles) Amarok will start
playback if it's running. If Amarok is not running, VLC will pause
the playback. This shows that a multi-media application should not
globally grab these keys.
In addition we just introduced a change [1] in plasma-workspace for the
Plasma/5.3 release to grab these shortcuts and bind them to the
mpris2 dataengine. Now the mpris2 engine handles those shortcuts and
delegates to the currently active application.
[1] http://commits.kde.org/plasma-workspace/409fdfab03e7a0b5a61e7796e1fba85b143eab3b</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ActionClasses.cpp <span style="color: \
grey">(3f6a63e073f76db8ec05daf531dd2d828d3f9c0d)</span></li>
<li>src/MainWindow.cpp <span style="color: \
grey">(484f4251f8911f1c4e63f61ae17efd7b17b5c4e6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122450/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6382908233331439430==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic