'Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons'

[prev in list] [next in list] [prev in thread] [next in thread] 

List: kde-panel-devel
Subject: Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2015-02-27 12:24:04
Message-ID: 20150227122404.12884.45319 () probe ! kde ! org
[Download RAW message or body]

--===============5941337914274659644==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On Jan. 26, 2015, 9:08 a.m., Marco Martin wrote:
> > where do you want to use it?
> > Iirc Bhushan is working o a global way to make series of kcms \
> > accessible from plasmoids
> 
> David Edmundson wrote:
> Generic is always better.
> KDeclarative is used from places outside Plasma. Applications in future \
> will need to open KCMs too. If we put it in Plasma in one year we'll end \
> up with this anyway and we end up maintaining a weird system used only by \
> us. 
> Also from a discussion on IRC you'll end up guessing the name to put in \
> the UI. This will lead to blocking developers from being able to do the \
> right thing by trying to be too clever. 
> Bhushan Shah wrote:
> My suggestion is to have both this can be used by applets if they don't \
> like solution provided by plasma-framework OR optionally turn this into \
> simple processrunner, there are use cases for both methods 
> Marco Martin wrote:
> apart that reading an "always" makes me cringe :p
> what I really don't like is the ui inconsistencies that this will cause \
> (an encourages). They will happen anyways true, but at least a timid \
> attempt at fighting that could be done (this was always been a problem in \
> KDE, wasn't it..), creating a path of least resistence and trying to \
> enforce it is an approach. 
> in the end is mostly a technical problem, since the actual proper \
> solution (putting them in the configure dialog) is not possible anymore. \
> if some day this will be possible again (for instance kcms in qml) that \
> should be the preferred way again, so both approaches are in the end just \
> workarounds, so... whatever (/me shrugs) 
> Bhushan Shah wrote:
> Or another option is something like https://paste.kde.org/pirqonxvl 
> 
> so that you can just do plasmoid.openConfigurationModules()
> 
> Sebastian Kügler wrote:
> It would be possible if we made the applet's config dialog a QWidget (the \
> KCM container) and put a QML container into that to load the actual \
> config modules for the applet. The problem with this approach is that \
> it's the exact opposite direction we have been going to, but at least \
> it's not hidden from the API. 
> I'm not proposing this, just bringing it up since it came up in my head: \
> food for thought. 
> Kai Uwe Broulik wrote:
> That could also give us back the widget sidebar looking consistent with \
> the KCMs if we used a traditional window with a sidebar and then have \
> pages for each of the qml config pages and add additional KCMs there as \
> needed. For other formfactors the old all-QML view could be used again, \
> given that widget-based apps don't really fit into a touch environment \
> anyway. On the other hand, isn't systemsettings destined to become \
> QtQuick-based eventually? 
> Marco Martin wrote:
> yeah, *can* be done, but i consider it really a step back at this point. \
> it's problem was mostly a "too soon" but still think was the right \
> direction 
> Sebastian Kügler wrote:
> I lean towards not going this step back as well. Not that I have an \
> alternative solution to offer, though. :/ 
> Kai Uwe Broulik wrote:
> So, what do we do then? :)

For this particular patch, Ship it from my side. I'll let someone else \
check the checkbox to make sure we agree.

- Sebastian

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122239/#review74750
-----------------------------------------------------------

On Jan. 24, 2015, 11:54 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122239/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2015, 11:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> Since there are already like 10 copies of the ProcessRunner for all kinds \
> of plasmoids wanting to open a KCM, this adds a KCMShell.open("foo") and \
> KCMShell.open(["foo", "bar", "baz"]) singleton. 
> 
> Diffs
> -----
> 
> src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 65e28ff 
> src/qmlcontrols/kquickcontrolsaddons/kcmshell.h PRE-CREATION 
> src/qmlcontrols/kquickcontrolsaddons/kcmshell.cpp PRE-CREATION 
> src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp \
> 289f1ed  
> Diff: https://git.reviewboard.kde.org/r/122239/diff/
> 
> 
> Testing
> -------
> 
> Works. Dunno if the name causes clashes or this is the right place to put \
> it. 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
> 

--===============5941337914274659644==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: \
1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122239/">https://git.reviewboard.kde.org/r/122239/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> On January 26th, 2015, \
9:08 a.m. UTC, Marco Martin wrote: <blockquote \
style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">where do you want to use it? \
Iirc Bhushan is working o a global way to make series of kcms accessible \
from plasmoids</pre> </blockquote>

 <p>On January 26th, 2015, 1:09 p.m. UTC, <b>David Edmundson</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Generic is always better. \
KDeclarative is used from places outside Plasma. Applications in future \
will need to open KCMs too. If we put it in Plasma in one year we'll end up \
with this anyway and we end up maintaining a weird system used only by \
us.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Also from a discussion on IRC you'll end up \
guessing the name to put in the UI. This will lead to blocking developers \
from being able to do the right thing by trying to be too clever.</p></pre> \
</blockquote>

 <p>On January 26th, 2015, 1:19 p.m. UTC, <b>Bhushan Shah</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">My suggestion is to have both \
this can be used by applets if they don't like solution provided by \
plasma-framework OR optionally turn this into simple processrunner, there \
are use cases for both methods</p></pre>  </blockquote>

 <p>On January 26th, 2015, 1:24 p.m. UTC, <b>Marco Martin</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">apart that reading an \
"always" makes me cringe :p what I really don't like is the ui \
inconsistencies that this will cause (an encourages). They will happen \
anyways true, but at least a timid attempt at fighting that could be done \
(this was always been a problem in KDE, wasn't it..), creating a path of \
least resistence and trying to enforce it is an approach.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">in the end is mostly a technical problem, \
since the actual proper solution (putting them in the configure dialog) is \
not possible anymore. if some day this will be possible again (for instance \
kcms in qml) that should be the preferred way again, so both approaches are \
in the end just workarounds, so... whatever (/me shrugs)</p></pre>  \
</blockquote>

 <p>On January 28th, 2015, 5:53 a.m. UTC, <b>Bhushan Shah</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Or another option is \
something like https://paste.kde.org/pirqonxvl </p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">so that you can just do \
plasmoid.openConfigurationModules()</p></pre>  </blockquote>

 <p>On January 28th, 2015, 3:56 p.m. UTC, <b>Sebastian Kügler</b> \
wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; \
white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">It would be \
possible if we made the applet's config dialog a QWidget (the KCM \
container) and put a QML container into that to load the actual config \
modules for the applet. The problem with this approach is that it's the \
exact opposite direction we have been going to, but at least it's not \
hidden from the API.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm not \
proposing this, just bringing it up since it came up in my head: food for \
thought.</p></pre>  </blockquote>

 <p>On February 7th, 2015, 4:32 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">That could also give us back \
the widget sidebar looking consistent with the KCMs if we used a \
traditional window with a sidebar and then have pages for each of the qml \
config pages and add additional KCMs there as needed. For other formfactors \
the old all-QML view could be used again, given that widget-based apps \
don't really fit into a touch environment anyway. On the other hand, isn't \
systemsettings destined to become QtQuick-based eventually?</p></pre>  \
</blockquote>

 <p>On February 9th, 2015, 9:23 a.m. UTC, <b>Marco Martin</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">yeah, <em style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">can</em> be done, but i consider it really a step back at this \
point. it's problem was mostly a "too soon" but still think was the right \
direction</p></pre>  </blockquote>

 <p>On February 9th, 2015, 11:44 a.m. UTC, <b>Sebastian Kügler</b> \
wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; \
white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I lean \
towards not going this step back as well. Not that I have an alternative \
solution to offer, though. :/</p></pre>  </blockquote>

 <p>On February 26th, 2015, 9:41 p.m. UTC, <b>Kai Uwe Broulik</b> \
wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; \
white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">So, what do \
we do then? :)</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">For this particular patch, Ship it from my \
side. I'll let someone else check the checkbox to make sure we \
agree.</p></pre> <br />

<p>- Sebastian</p>

<br />
<p>On January 24th, 2015, 11:54 p.m. UTC, Kai Uwe Broulik wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" \
style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: \
6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Jan. 24, 2015, 11:54 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeclarative
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Since there are already like \
10 copies of the ProcessRunner for all kinds of plasmoids wanting to open a \
KCM, this adds a KCMShell.open("foo") and KCMShell.open(["foo", "bar", \
"baz"]) singleton.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Works. Dunno if the name \
causes clashes or this is the right place to put it.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt <span \
style="color: grey">(65e28ff)</span></li>

 <li>src/qmlcontrols/kquickcontrolsaddons/kcmshell.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/qmlcontrols/kquickcontrolsaddons/kcmshell.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp \
<span style="color: grey">(289f1ed)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122239/diff/" \
style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5941337914274659644==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 