From kde-panel-devel Thu Feb 26 18:53:17 2015 From: "Alex Richardson" Date: Thu, 26 Feb 2015 18:53:17 +0000 To: kde-panel-devel Subject: Re: Review Request 122312: Use sysconf() instead of relying on UT_NAMESIZE Message-Id: <20150226185317.12884.7221 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=142497682110171 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0165850937360624008==" --===============0165850937360624008== Content-Type: multipart/alternative; boundary="===============6211324314220874138==" --===============6211324314220874138== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122312/ ----------------------------------------------------------- (Updated Feb. 26, 2015, 6:53 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma and Raphael Kubo da Costa. Repository: user-manager Description ------- Use sysconf() instead of relying on UT_NAMESIZE This will work on any UNIX system even those that don't have utmp.h such as FreeBSD. Diffs ----- src/accountinfo.cpp 68fc865 Diff: https://git.reviewboard.kde.org/r/122312/diff/ Testing ------- compiles, runs and shows user name too long tooltip when I enter a really long name Thanks, Alex Richardson --===============6211324314220874138== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122312/

This change has been marked as submitted.

Review request for Plasma and Raphael Kubo da Costa.

By Alex Richardson.

Updated Feb. 26, 2015, 6:53 p.m.

Repository: user-manager

Description

Use sysconf() instead of relying on UT_NAMESIZE

This will work on any UNIX system even those that don't have utmp.h such as FreeBSD.

Testing

compiles, runs and shows user name too long tooltip when I enter a really long name

Diffs

src/accountinfo.cpp (68fc865)

View Diff

--===============6211324314220874138==-- --===============0165850937360624008== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============0165850937360624008==--