'Re: Review Request 122598: Add separate checkbox for automatically lock screen'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 122598: Add separate checkbox for automatically lock screen
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2015-02-26 12:06:23
Message-ID: 20150226120623.12883.72975 () probe ! kde ! org
[Download RAW message or body]

--===============4580028553416574990==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122598/
-----------------------------------------------------------

(Updated Feb. 26, 2015, 12:06 p.m.)

Review request for Plasma.

Repository: plasma-workspace

Description
-------

This improves usability over setting the timeout to 0.
Defaults behaviour is unchanged

BUG: 342596

Diffs (updated)
-----

  ksmserver/screenlocker/kcm/kcm.ui fe32cf3 
  ksmserver/screenlocker/ksldapp.cpp 6c41f4e 
  ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg d5a82b7 

Diff: https://git.reviewboard.kde.org/r/122598/diff/

Testing
-------

File Attachments (updated)
----------------

a.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/02/16/858a9415-352d-48c5-bb1c-e2b60b23ab06__a.png
 aleix suggests doing this...thoughts?
  https://git.reviewboard.kde.org/media/uploaded/files/2015/02/16/4d9fbaed-dca8-4000-913e-c352696a975f__a1.png
 this?
  https://git.reviewboard.kde.org/media/uploaded/files/2015/02/26/e4196951-0578-4149-914f-d310efe70ce2__this.png

Thanks,

David Edmundson

--===============4580028553416574990==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122598/">https://git.reviewboard.kde.org/r/122598/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated Feb. 26, 2015, 12:06 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This improves usability over setting the timeout to 0. \
Defaults behaviour is unchanged</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">BUG: 342596</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>ksmserver/screenlocker/kcm/kcm.ui <span style="color: \
grey">(fe32cf3)</span></li>

 <li>ksmserver/screenlocker/ksldapp.cpp <span style="color: \
grey">(6c41f4e)</span></li>

 <li>ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg <span style="color: \
grey">(d5a82b7)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122598/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
(updated)</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/02/16/858a9415-352d-48c5-bb1c-e2b60b23ab06__a.png">a.png</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/02/16/4d9fbaed-dca8-4000-913e-c352696a975f__a1.png">aleix \
suggests doing this...thoughts?</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/02/26/e4196951-0578-4149-914f-d310efe70ce2__this.png">this?</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4580028553416574990==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 