[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Review Request 122668: port of comic applet to plasma5
From: "Marco Martin" <notmart () gmail ! com>
Date: 2015-02-25 17:01:01
Message-ID: 20150225170101.12884.16462 () probe ! kde ! org
[Download RAW message or body]
--===============3843673792680689151==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122668/
-----------------------------------------------------------
Review request for Plasma.
Repository: kdeplasma-addons
Description
-------
this ports the comic applet to plasma5 (and the dataengine to kpackage, dropping the \
support of c++ comic plugins that don't exist anymore since KDE 4.3 anyways)
Diffs
-----
dataengines/comic/comicproviderkross.h d80a686
dataengines/comic/comicprovider.h db3c3f1
dataengines/comic/comic.h 38a3cc2
dataengines/CMakeLists.txt 41288df
applets/comic/plasma-comic-default.desktop 69874bf
applets/comic/package/contents/ui/main.qml 1862475
applets/comic/package/contents/ui/configGeneral.qml PRE-CREATION
applets/comic/package/contents/ui/configAppearance.qml PRE-CREATION
applets/comic/package/contents/ui/configAdvanced.qml PRE-CREATION
applets/comic/package/contents/ui/ImageWidget.qml e450db6
applets/comic/package/contents/ui/FullViewWidget.qml f76bd4c
applets/comic/package/contents/ui/ComicCentralView.qml 4204ddc
applets/comic/appearanceSettings.ui 5dc1144
applets/comic/comicdata.h 696dc8a
applets/comic/comicinfo.cpp c7372ae
applets/comic/comicmodel.h 87b5a0f
applets/comic/comicmodel.cpp 349019d
applets/comic/comicsaver.cpp cf92c76
applets/comic/comicupdater.h PRE-CREATION
applets/comic/comicupdater.cpp PRE-CREATION
applets/comic/configwidget.h 0bf450f
applets/comic/configwidget.cpp 0d7b149
applets/comic/package/contents/config/config.qml PRE-CREATION
applets/comic/package/contents/ui/ButtonBar.qml d10b915
applets/comic/comicarchivedialog.cpp 35902d8
applets/comic/comicarchivejob.h 2ee1428
dataengines/comic/comicprovider.cpp 2e5bb16
dataengines/comic/comic_package.cpp c4d466f
dataengines/comic/comicproviderkross.cpp c2c9ee9
dataengines/comic/comicproviderwrapper.h 499f338
dataengines/comic/comicproviderwrapper.cpp f60a4f6
dataengines/comic/plasma-packagestructure-comic.desktop e05786a
applets/comic/package/contents/ui/ComicBottomInfo.qml f5885b1
applets/comic/comicdata.cpp f61be2f
applets/comic/comicarchivejob.cpp 68b42d2
applets/comic/comicarchivedialog.h 2bd6551
applets/comic/comic.knsrc e9ddbf7
applets/comic/checknewstrips.cpp 8558c9e
applets/comic/advancedsettings.ui 9fc4d21
applets/comic/CMakeLists.txt 9b41b99
CMakeLists.txt 45d05c7
applets/CMakeLists.txt c65250a
dataengines/comic/comic.cpp 5eab3fc
dataengines/comic/comic_package.h 06b4b52
dataengines/comic/CMakeLists.txt 28ef44f
applets/comic/stripselector.cpp cd88ea3
applets/comic/package/metadata.desktop c015137
applets/comic/comicSettings.ui fd73d47
applets/comic/comic.h d460b11
applets/comic/comic.cpp 8352eee
Diff: https://git.reviewboard.kde.org/r/122668/diff/
Testing
-------
Thanks,
Marco Martin
--===============3843673792680689151==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122668/">https://git.reviewboard.kde.org/r/122668/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">this ports the comic applet to plasma5 (and the \
dataengine to kpackage, dropping the support of c++ comic plugins that don't exist \
anymore since KDE 4.3 anyways)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dataengines/comic/comicproviderkross.h <span style="color: \
grey">(d80a686)</span></li>
<li>dataengines/comic/comicprovider.h <span style="color: \
grey">(db3c3f1)</span></li>
<li>dataengines/comic/comic.h <span style="color: grey">(38a3cc2)</span></li>
<li>dataengines/CMakeLists.txt <span style="color: grey">(41288df)</span></li>
<li>applets/comic/plasma-comic-default.desktop <span style="color: \
grey">(69874bf)</span></li>
<li>applets/comic/package/contents/ui/main.qml <span style="color: \
grey">(1862475)</span></li>
<li>applets/comic/package/contents/ui/configGeneral.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/comic/package/contents/ui/configAppearance.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/comic/package/contents/ui/configAdvanced.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/comic/package/contents/ui/ImageWidget.qml <span style="color: \
grey">(e450db6)</span></li>
<li>applets/comic/package/contents/ui/FullViewWidget.qml <span style="color: \
grey">(f76bd4c)</span></li>
<li>applets/comic/package/contents/ui/ComicCentralView.qml <span style="color: \
grey">(4204ddc)</span></li>
<li>applets/comic/appearanceSettings.ui <span style="color: \
grey">(5dc1144)</span></li>
<li>applets/comic/comicdata.h <span style="color: grey">(696dc8a)</span></li>
<li>applets/comic/comicinfo.cpp <span style="color: grey">(c7372ae)</span></li>
<li>applets/comic/comicmodel.h <span style="color: grey">(87b5a0f)</span></li>
<li>applets/comic/comicmodel.cpp <span style="color: grey">(349019d)</span></li>
<li>applets/comic/comicsaver.cpp <span style="color: grey">(cf92c76)</span></li>
<li>applets/comic/comicupdater.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/comic/comicupdater.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/comic/configwidget.h <span style="color: grey">(0bf450f)</span></li>
<li>applets/comic/configwidget.cpp <span style="color: grey">(0d7b149)</span></li>
<li>applets/comic/package/contents/config/config.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/comic/package/contents/ui/ButtonBar.qml <span style="color: \
grey">(d10b915)</span></li>
<li>applets/comic/comicarchivedialog.cpp <span style="color: \
grey">(35902d8)</span></li>
<li>applets/comic/comicarchivejob.h <span style="color: grey">(2ee1428)</span></li>
<li>dataengines/comic/comicprovider.cpp <span style="color: \
grey">(2e5bb16)</span></li>
<li>dataengines/comic/comic_package.cpp <span style="color: \
grey">(c4d466f)</span></li>
<li>dataengines/comic/comicproviderkross.cpp <span style="color: \
grey">(c2c9ee9)</span></li>
<li>dataengines/comic/comicproviderwrapper.h <span style="color: \
grey">(499f338)</span></li>
<li>dataengines/comic/comicproviderwrapper.cpp <span style="color: \
grey">(f60a4f6)</span></li>
<li>dataengines/comic/plasma-packagestructure-comic.desktop <span style="color: \
grey">(e05786a)</span></li>
<li>applets/comic/package/contents/ui/ComicBottomInfo.qml <span style="color: \
grey">(f5885b1)</span></li>
<li>applets/comic/comicdata.cpp <span style="color: grey">(f61be2f)</span></li>
<li>applets/comic/comicarchivejob.cpp <span style="color: \
grey">(68b42d2)</span></li>
<li>applets/comic/comicarchivedialog.h <span style="color: \
grey">(2bd6551)</span></li>
<li>applets/comic/comic.knsrc <span style="color: grey">(e9ddbf7)</span></li>
<li>applets/comic/checknewstrips.cpp <span style="color: grey">(8558c9e)</span></li>
<li>applets/comic/advancedsettings.ui <span style="color: \
grey">(9fc4d21)</span></li>
<li>applets/comic/CMakeLists.txt <span style="color: grey">(9b41b99)</span></li>
<li>CMakeLists.txt <span style="color: grey">(45d05c7)</span></li>
<li>applets/CMakeLists.txt <span style="color: grey">(c65250a)</span></li>
<li>dataengines/comic/comic.cpp <span style="color: grey">(5eab3fc)</span></li>
<li>dataengines/comic/comic_package.h <span style="color: \
grey">(06b4b52)</span></li>
<li>dataengines/comic/CMakeLists.txt <span style="color: grey">(28ef44f)</span></li>
<li>applets/comic/stripselector.cpp <span style="color: grey">(cd88ea3)</span></li>
<li>applets/comic/package/metadata.desktop <span style="color: \
grey">(c015137)</span></li>
<li>applets/comic/comicSettings.ui <span style="color: grey">(fd73d47)</span></li>
<li>applets/comic/comic.h <span style="color: grey">(d460b11)</span></li>
<li>applets/comic/comic.cpp <span style="color: grey">(8352eee)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122668/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3843673792680689151==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic