'Review Request 122715: tooltip: Fix left margin in text-only tooltips'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request 122715: tooltip: Fix left margin in text-only tooltips
From:       Sebastian_Kügler <sebas () kde ! org>
Date:       2015-02-25 1:00:41
Message-ID: 20150225010041.12883.54838 () probe ! kde ! org
[Download RAW message or body]

--===============2326461150165064899==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122715/
-----------------------------------------------------------

Review request for Plasma.

Repository: plasma-framework

Description
-------

tooltip: Fix left margin in text-only tooltips

Changelog: Fix text-only tooltips' left margin

The approach taken is a bit ugly, since we don't have control over exact placing due \
to the usage of Row and Column. The existing x and y properties are also pretty ugly. \
I'm going for a spacer object and making the spacing zero here, as that is much \
easier to compute than preventing from double or triple spacing.

I think this code needs a rewrite. This is a minimal approach to fixing the alignment \
of the pager, for example.

Diffs
-----

  src/declarativeimports/core/private/DefaultToolTip.qml \
d1be6ae42d1c093100201dd9e20670edd6381c57 

Diff: https://git.reviewboard.kde.org/r/122715/diff/

Testing
-------

Tested pager individually, checked all tooltip from the panel for visual regressions.

Thanks,

Sebastian Kügler

--===============2326461150165064899==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122715/">https://git.reviewboard.kde.org/r/122715/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Sebastian Kügler.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">tooltip: Fix left margin in text-only tooltips</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Changelog: Fix text-only tooltips' left margin</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
approach taken is a bit ugly, since we don't have control over exact placing due to \
the usage of Row and Column. The existing x and y properties are also pretty ugly. \
I'm going for a spacer object and making the spacing zero here, as that is much \
easier to compute than preventing from double or triple spacing.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I think this code needs a rewrite. This is a minimal approach to fixing the \
alignment of the pager, for example.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested pager individually, checked all tooltip from \
the panel for visual regressions.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/declarativeimports/core/private/DefaultToolTip.qml <span style="color: \
grey">(d1be6ae42d1c093100201dd9e20670edd6381c57)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122715/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2326461150165064899==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 