[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 122704: Set aboutdata for plasmashell
From: "Bhushan Shah" <bhush94 () gmail ! com>
Date: 2015-02-24 7:22:27
Message-ID: 20150224072227.12884.28089 () probe ! kde ! org
[Download RAW message or body]
--===============4244868976601726504==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122704/
-----------------------------------------------------------
(Updated Feb. 24, 2015, 7:22 a.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma and Christoph Feck.
Repository: plasma-workspace
Description
-------
This patch sets aboutdata for plasmashell,
If aboutData is not set it results in some problems, for example kcrash do not report \
to right product for crash on bko
For example see following bug reports
https://bugs.kde.org/show_bug.cgi?id=344471
https://bugs.kde.org/show_bug.cgi?id=344323
They gets reported to kde/general
Diffs
-----
shell/CMakeLists.txt 21b25a3
shell/main.cpp 987bf44
Diff: https://git.reviewboard.kde.org/r/122704/diff/
Testing
-------
Reported two new bugs, in first bug it was reported to kde/general because \
plasmashell didn't had version number for 5.2.90, second bug got reported properly
https://bugs.kde.org/show_bug.cgi?id=344513
https://bugs.kde.org/show_bug.cgi?id=344514
Thanks,
Bhushan Shah
--===============4244868976601726504==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122704/">https://git.reviewboard.kde.org/r/122704/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Christoph Feck.</div>
<div>By Bhushan Shah.</div>
<p style="color: grey;"><i>Updated Feb. 24, 2015, 7:22 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch sets aboutdata for plasmashell,</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">If aboutData is not set it results in some problems, for example kcrash do \
not report to right product for crash on bko</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">For example see \
following bug reports</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: \
inherit;">https://bugs.kde.org/show_bug.cgi?id=344471 \
https://bugs.kde.org/show_bug.cgi?id=344323</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">They gets reported to \
kde/general</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Reported two new bugs, in first bug it was reported to \
kde/general because plasmashell didn't had version number for 5.2.90, second bug got \
reported properly</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: \
inherit;">https://bugs.kde.org/show_bug.cgi?id=344513 \
https://bugs.kde.org/show_bug.cgi?id=344514</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/CMakeLists.txt <span style="color: grey">(21b25a3)</span></li>
<li>shell/main.cpp <span style="color: grey">(987bf44)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122704/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4244868976601726504==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic