'Re: Review Request 122408: allow to cycle through activities from global shortcuts plugin'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 122408: allow to cycle through activities from global shortcuts plugin
From:       "Bhushan Shah" <bhush94 () gmail ! com>
Date:       2015-02-24 7:02:27
Message-ID: 20150224070227.12883.61796 () probe ! kde ! org
[Download RAW message or body]

--===============4810716598528497597==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122408/
-----------------------------------------------------------

(Updated Feb. 24, 2015, 12:32 p.m.)

Status
------

This change has been discarded.

Review request for KDE Frameworks, Plasma and Ivan Čukić.

Bugs: 342186
    http://bugs.kde.org/show_bug.cgi?id=342186

Repository: kactivities

Description
-------

Currently shellcorona registeres those shortcuts but that is not right place and it \
is not working there, so this is place where this should be done

Diffs
-----

  src/service/plugins/globalshortcuts/GlobalShortcutsPlugin.h 54a24a8 
  src/service/plugins/globalshortcuts/GlobalShortcutsPlugin.cpp 1a13b6b 

Diff: https://git.reviewboard.kde.org/r/122408/diff/

Testing
-------

alt+tab, alt+s works to cycle activities and stop activities but somehow \
alt+shift+tab is not working due to some kglobalaccel limitation.

Thanks,

Bhushan Shah

--===============4810716598528497597==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122408/">https://git.reviewboard.kde.org/r/122408/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, Plasma and Ivan Čukić.</div>
<div>By Bhushan Shah.</div>

<p style="color: grey;"><i>Updated Feb. 24, 2015, 12:32 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=342186">342186</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kactivities
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Currently shellcorona registeres those shortcuts but \
that is not right place and it is not working there, so this is place where this \
should be done</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">alt+tab, alt+s works to cycle activities and stop \
activities but somehow alt+shift+tab is not working due to some kglobalaccel \
limitation.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/service/plugins/globalshortcuts/GlobalShortcutsPlugin.h <span style="color: \
grey">(54a24a8)</span></li>

 <li>src/service/plugins/globalshortcuts/GlobalShortcutsPlugin.cpp <span \
style="color: grey">(1a13b6b)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122408/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4810716598528497597==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 