[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 122452: [shell] Emit dbus signals in org.kde.osdService
From: "Heiko Tietze" <heiko.tietze () user-prompt ! com>
Date: 2015-02-20 9:54:00
Message-ID: 20150220095400.4988.13003 () probe ! kde ! org
[Download RAW message or body]
--===============9215269653803780882==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Feb. 20, 2015, 9:39 vorm., Heiko Tietze wrote:
> > Design with transparent background is nice. But please consider multiple \
> > notifications. For instance, "You got 5 new mails", "You have been mentioned on \
> > IRC", plus the loudness indicator. It would be nice to not only show the last \
> > item but to implement a carousell pattern.
>
> Martin Gräßlin wrote:
> Heiko: this is just the OSD, not notificatons. For the notifications I created a \
> forum thread in VDG, with not much feedback so far.
And I thought you want to get the feedback here :-).
- Heiko
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122452/#review76325
-----------------------------------------------------------
On Feb. 10, 2015, 10:07 vorm., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122452/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2015, 10:07 vorm.)
>
>
> Review request for Plasma and Martin Klapetek.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Emitting dbus signals allows interested parties to be notified about
> OSD changes. E.g. the lock screen might want to show the OSD values,
> but blocks the actual OSD, so it needs to be informed about changes
> to react on them.
>
> [lookandfeel] Split mainItem of Osd into a dedicated OsdItem
>
> Allows to reuse the content of the Osd in other parts without
> having it to be a Dialog.
>
> [screenlocker] Support OnScreenDisplay messages
>
> KSld connects to the DBus signals for the OnScreenDisplay and forwards
> them to the greeter application through the private Wayland protocol.
> The idea here is to not have the greeter connect to the DBus as in future
> it would be preferable if the greeter cannot connect to DBus.
>
> The lookandfeel package might expose an object called "onScreenDisplay".
> Whenever an OSD message is recieved by the greeter it looks for such an
> object and updates the osd specific properties.
>
> The default breeze lookandfeel package integrates the OsdItem from the
> same lookandfeel package.
>
>
> Diffs
> -----
>
> ksmserver/screenlocker/greeter/greeterapp.h \
> 4a90fafee810940c3f932c8e2bfed10459adc425 \
> ksmserver/screenlocker/greeter/greeterapp.cpp \
> a23b5625adc99661ab07534403ee23d005581c03 ksmserver/screenlocker/protocols/ksld.xml \
> bfb32190bf2529a14b39fac4c7e6029a5df811d0 ksmserver/screenlocker/waylandserver.h \
> 5a8ed2249152277b505fe7a944b1b7251ef995d3 ksmserver/screenlocker/waylandserver.cpp \
> 746032e1a7b1bad3625b9f0a156de059e5fba31a \
> lookandfeel/contents/lockscreen/LockScreen.qml \
> 1c4e4a510dd9196ae2b36bc355490580c06a78a6 lookandfeel/contents/osd/Osd.qml \
> b63338c2f94c074b405bba5509623ef38eef5350 lookandfeel/contents/osd/OsdItem.qml \
> PRE-CREATION shell/osd.h 356b073b2b9c88e57c324701ae47e0e969b75a51
> shell/osd.cpp b5d40ab3539bbbe37386fa6ecf4a1f8cb130c100
>
> Diff: https://git.reviewboard.kde.org/r/122452/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Lock screen with volume OSD
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/06/7e2f82a5-4ec4-46cc-9697-7cead41d2a45__missing-tasks-applet1.png
> With background
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/09/05e26071-2b79-4c75-85af-68cff6e163ee__missing-tasks-applet1.png
>
>
> Thanks,
>
> Martin Gräßlin
>
>
--===============9215269653803780882==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122452/">https://git.reviewboard.kde.org/r/122452/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Februar 20th, 2015, 9:39 vorm. UTC, <b>Heiko \
Tietze</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Design with transparent background is nice. But please \
consider multiple notifications. For instance, "You got 5 new mails", "You have been \
mentioned on IRC", plus the loudness indicator. It would be nice to not only show the \
last item but to implement a carousell pattern.</p></pre> </blockquote>
<p>On Februar 20th, 2015, 9:52 vorm. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Heiko: this is just the OSD, not notificatons. For the notifications I \
created a forum thread in VDG, with not much feedback so far.</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">And I \
thought you want to get the feedback here :-).</p></pre> <br />
<p>- Heiko</p>
<br />
<p>On Februar 10th, 2015, 10:07 vorm. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Martin Klapetek.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Feb. 10, 2015, 10:07 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Emitting dbus signals allows interested parties to be \
notified about OSD changes. E.g. the lock screen might want to show the OSD values,
but blocks the actual OSD, so it needs to be informed about changes
to react on them.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">[lookandfeel] Split mainItem of Osd into a dedicated \
OsdItem</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Allows to reuse the content of the Osd in other parts \
without having it to be a Dialog.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">[screenlocker] Support OnScreenDisplay messages</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">KSld connects to the DBus signals for the OnScreenDisplay and forwards them \
to the greeter application through the private Wayland protocol. The idea here is to \
not have the greeter connect to the DBus as in future it would be preferable if the \
greeter cannot connect to DBus.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">The lookandfeel package \
might expose an object called "onScreenDisplay". Whenever an OSD message is recieved \
by the greeter it looks for such an object and updates the osd specific \
properties.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The default breeze lookandfeel package integrates the \
OsdItem from the same lookandfeel package.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/screenlocker/greeter/greeterapp.h <span style="color: \
grey">(4a90fafee810940c3f932c8e2bfed10459adc425)</span></li>
<li>ksmserver/screenlocker/greeter/greeterapp.cpp <span style="color: \
grey">(a23b5625adc99661ab07534403ee23d005581c03)</span></li>
<li>ksmserver/screenlocker/protocols/ksld.xml <span style="color: \
grey">(bfb32190bf2529a14b39fac4c7e6029a5df811d0)</span></li>
<li>ksmserver/screenlocker/waylandserver.h <span style="color: \
grey">(5a8ed2249152277b505fe7a944b1b7251ef995d3)</span></li>
<li>ksmserver/screenlocker/waylandserver.cpp <span style="color: \
grey">(746032e1a7b1bad3625b9f0a156de059e5fba31a)</span></li>
<li>lookandfeel/contents/lockscreen/LockScreen.qml <span style="color: \
grey">(1c4e4a510dd9196ae2b36bc355490580c06a78a6)</span></li>
<li>lookandfeel/contents/osd/Osd.qml <span style="color: \
grey">(b63338c2f94c074b405bba5509623ef38eef5350)</span></li>
<li>lookandfeel/contents/osd/OsdItem.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>shell/osd.h <span style="color: \
grey">(356b073b2b9c88e57c324701ae47e0e969b75a51)</span></li>
<li>shell/osd.cpp <span style="color: \
grey">(b5d40ab3539bbbe37386fa6ecf4a1f8cb130c100)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122452/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/02/06/7e2f82a5-4ec4-46cc-9697-7cead41d2a45__missing-tasks-applet1.png">Lock \
screen with volume OSD</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/02/09/05e26071-2b79-4c75-85af-68cff6e163ee__missing-tasks-applet1.png">With \
background</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============9215269653803780882==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic