[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 122318: Sort apps by name if configured
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2015-02-04 8:48:05
Message-ID: 20150204084805.19249.85056 () probe ! kde ! org
[Download RAW message or body]
--===============0168794649893617534==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122318/#review75356
-----------------------------------------------------------
Ship it!
Ship It!
- David Edmundson
On Jan. 29, 2015, 10:02 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122318/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2015, 10:02 p.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 343538
> https://bugs.kde.org/show_bug.cgi?id=343538
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> The "show apps by name" option only affected the visual representation, it did not \
> change the actual sorting.
>
> Diffs
> -----
>
> applets/kickoff/core/applicationmodel.h e7399e8
> applets/kickoff/core/applicationmodel.cpp 8d2f885
> applets/kickoff/package/contents/ui/ApplicationsView.qml 9382882
>
> Diff: https://git.reviewboard.kde.org/r/122318/diff/
>
>
> Testing
> -------
>
> Now the items are always sorted alphabetically by whatever is written in the larger \
> font.
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============0168794649893617534==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122318/">https://git.reviewboard.kde.org/r/122318/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship \
It!</p></pre> <br />
<p>- David Edmundson</p>
<br />
<p>On January 29th, 2015, 10:02 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Jan. 29, 2015, 10:02 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=343538">343538</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The "show apps by name" option only affected the \
visual representation, it did not change the actual sorting.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Now the items are always sorted alphabetically by \
whatever is written in the larger font.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/kickoff/core/applicationmodel.h <span style="color: \
grey">(e7399e8)</span></li>
<li>applets/kickoff/core/applicationmodel.cpp <span style="color: \
grey">(8d2f885)</span></li>
<li>applets/kickoff/package/contents/ui/ApplicationsView.qml <span style="color: \
grey">(9382882)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122318/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0168794649893617534==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic