[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 122384: Simplify and fix use of IconThemePath in StatusNotifierItems
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2015-02-02 16:54:31
Message-ID: 20150202165431.19249.31681 () probe ! kde ! org
[Download RAW message or body]
--===============0770741611376168518==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Feb. 2, 2015, 3:43 p.m., Aleix Pol Gonzalez wrote:
> > dataengines/statusnotifieritem/statusnotifieritemsource.cpp, line 221
> > <https://git.reviewboard.kde.org/r/122384/diff/1/?file=346430#file346430line221>
> >
> > Braces not needed.
>
> Marco Martin wrote:
> I prefer doing like kdelibs everywhere requiring braces even for one liners
he was referring to
QStringList( {} )
where the braces weren't needed for the intializer list.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122384/#review75221
-----------------------------------------------------------
On Feb. 2, 2015, 3:48 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122384/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2015, 3:48 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Simplify and fix IconThemePath in StatusNotifierItems
>
> KIconLoader gained a second argument in KF5 that allows one to pass an
> absolute path to a icons to search.
>
> This saves trying to guess the app name, and adding that. This fixes
> certain application icons not loading (for example radiotray)
>
>
> Diffs
> -----
>
> dataengines/statusnotifieritem/statusnotifieritemsource.cpp 04cbc1a
>
> Diff: https://git.reviewboard.kde.org/r/122384/diff/
>
>
> Testing
> -------
>
> Ran radiotray on a system with libappindicator.
> Confirmed I got icons correctly
>
>
> Thanks,
>
> David Edmundson
>
>
--===============0770741611376168518==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122384/">https://git.reviewboard.kde.org/r/122384/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 2nd, 2015, 3:43 p.m. UTC, <b>Aleix Pol \
Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/122384/diff/1/?file=346430#file346430line221" \
style="color: black; font-weight: bold; text-decoration: \
underline;">dataengines/statusnotifieritem/statusnotifieritemsource.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
StatusNotifierItemSource::refreshCallback(QDBusPendingCallWatcher *call)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">221</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">}</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">216</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span \
class="n">m_customIconLoader</span> <span class="o">=</span> <span \
class="k">new</span> <span class="n">KIconLoader</span><span class="p">(</span><span \
class="n">QString</span><span class="p">(),</span> <span \
class="n">QStringList</span><span class="p">({</span><span class="n">path</span><span \
class="p">}),</span> <span class="k">this</span><span class="p">);</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Braces not needed.</p></pre> </blockquote>
<p>On February 2nd, 2015, 3:46 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
prefer doing like kdelibs everywhere requiring braces even for one liners</p></pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">he was referring to </p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">QStringList( {} )</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">where the braces weren't needed for the intializer \
list.</p></pre> <br />
<p>- David</p>
<br />
<p>On February 2nd, 2015, 3:48 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Feb. 2, 2015, 3:48 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Simplify and fix IconThemePath in \
StatusNotifierItems</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">KIconLoader gained a second argument in \
KF5 that allows one to pass an absolute path to a icons to search.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This saves trying to guess the app name, and adding \
that. This fixes certain application icons not loading (for example \
radiotray)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Ran radiotray on a system with libappindicator. \
Confirmed I got icons correctly</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dataengines/statusnotifieritem/statusnotifieritemsource.cpp <span style="color: \
grey">(04cbc1a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122384/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0770741611376168518==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic