[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 122331: Add libinput support to kcm-touchpad
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2015-02-02 7:56:39
Message-ID: 20150202075639.19248.64883 () probe ! kde ! org
[Download RAW message or body]

--===============0322335095688557941==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122331/#review75195
-----------------------------------------------------------



src/backends/x11/libinputproperties.c
<https://git.reviewboard.kde.org/r/122331/#comment52002>

    C++11 nitpick: nullptr instead of NULL



src/backends/x11/xlibbackend.h
<https://git.reviewboard.kde.org/r/122331/#comment52003>

    const-ref?


- Martin Gräßlin


On Jan. 30, 2015, 8:41 p.m., Rajeesh K Nambiar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122331/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2015, 8:41 p.m.)
> 
> 
> Review request for Plasma, Alexander Mezin and Martin Gräßlin.
> 
> 
> Repository: kcm-touchpad
> 
> 
> Description
> -------
> 
> ibinput is a library to handle input devices in Wayland compositors and to provide \
> a generic X.Org input driver. Add libinput support to kcm-touchpad. Patch authored \
> by Peter Hutterer. 
> 
> Diffs
> -----
> 
> src/kcm/touchpad.kcfg 2afe642 
> src/kcm/ui/tap.ui 8e081ad 
> src/touchpadbackend.cpp 93e3dc2 
> src/backends/x11.cmake f208281 
> src/backends/x11/libinputproperties.c PRE-CREATION 
> src/backends/x11/synclientproperties.h 5b32b9f 
> src/backends/x11/xlibbackend.h 3692a60 
> src/backends/x11/xlibbackend.cpp 3b5e5be 
> src/kcm/customconfigdialogmanager.cpp 75b03ab 
> 
> Diff: https://git.reviewboard.kde.org/r/122331/diff/
> 
> 
> Testing
> -------
> 
> Fedora 21 RPM built and tested with Plasma 5.2.
> RPMs available here for testing: \
> https://copr-be.cloud.fedoraproject.org/results/rajeeshknambiar/kf5-kde-apps/fedora-21-x86_64/kf5-kcm_touchpad-5.1.96-1.fc21/
>  
> 
> Thanks,
> 
> Rajeesh K Nambiar
> 
> 


--===============0322335095688557941==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122331/">https://git.reviewboard.kde.org/r/122331/</a>
  </td>
    </tr>
   </table>
   <br />











<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/122331/diff/1/?file=345765#file345765line34" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/backends/x11/libinputproperties.c</a>  <span style="font-weight: \
normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">34</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="p">{</span> <span class="nb">NULL</span><span class="p">,</span> <span \
class="mi">0</span><span class="p">,</span> <span class="mi">0</span><span \
class="p">,</span> <span class="mi">0</span><span class="p">,</span> <span \
class="mi">0</span><span class="p">,</span> <span class="mi">0</span><span \
class="p">,</span> <span class="mi">0</span> <span class="p">}</span></pre></td>  \
</tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">C++11 \
nitpick: nullptr instead of NULL</p></pre>  </div>
</div>
<br />

<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/122331/diff/1/?file=345767#file345767line86" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/backends/x11/xlibbackend.h</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class \
XlibBackend : public TouchpadBackend</pre></td>

  </tr>
 </tbody>



 
 

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">84</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="kt">int</span> <span class="nf">findTouchpad</span><span \
class="p">();</span></pre></td>  <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">86</font></th>  <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; ">    <span class="kt">int</span> <span \
class="nf">findTouchpad</span><span class="p">(</span><span class="n"><span \
class="hl">XcbAtom</span></span><span class="hl"> </span><span class="o"><span \
class="hl">&amp;</span></span><span class="n"><span \
class="hl">identifier</span></span><span class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">const-ref?</p></pre>  </div>
</div>
<br />



<p>- Martin Gräßlin</p>


<br />
<p>On January 30th, 2015, 8:41 p.m. CET, Rajeesh K Nambiar wrote:</p>









<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma, Alexander Mezin and Martin Gräßlin.</div>
<div>By Rajeesh K Nambiar.</div>


<p style="color: grey;"><i>Updated Jan. 30, 2015, 8:41 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kcm-touchpad
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">ibinput is a library to handle input devices in \
Wayland compositors and to provide a generic X.Org input driver. Add libinput support \
to kcm-touchpad. Patch authored by Peter Hutterer.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Fedora 21 RPM built and tested with Plasma 5.2. RPMs \
available here for testing: \
https://copr-be.cloud.fedoraproject.org/results/rajeeshknambiar/kf5-kde-apps/fedora-21-x86_64/kf5-kcm_touchpad-5.1.96-1.fc21/</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kcm/touchpad.kcfg <span style="color: grey">(2afe642)</span></li>

 <li>src/kcm/ui/tap.ui <span style="color: grey">(8e081ad)</span></li>

 <li>src/touchpadbackend.cpp <span style="color: grey">(93e3dc2)</span></li>

 <li>src/backends/x11.cmake <span style="color: grey">(f208281)</span></li>

 <li>src/backends/x11/libinputproperties.c <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/backends/x11/synclientproperties.h <span style="color: \
grey">(5b32b9f)</span></li>

 <li>src/backends/x11/xlibbackend.h <span style="color: grey">(3692a60)</span></li>

 <li>src/backends/x11/xlibbackend.cpp <span style="color: grey">(3b5e5be)</span></li>

 <li>src/kcm/customconfigdialogmanager.cpp <span style="color: \
grey">(75b03ab)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122331/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>








  </div>
 </body>
</html>


--===============0322335095688557941==--



_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic