[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 122339: Add KWorkSpace::isShuttingDown()
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2015-02-02 7:45:26
Message-ID: 20150202074526.19248.6731 () probe ! kde ! org
[Download RAW message or body]
--===============5688498902343980945==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122339/#review75190
-----------------------------------------------------------
is that for the case that no logind is used? Or should ksmserver better integrate \
with logind?
- Martin Gräßlin
On Jan. 31, 2015, 5:02 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122339/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2015, 5:02 p.m.)
>
>
> Review request for Plasma and Martin Gräßlin.
>
>
> Bugs: 189456
> https://bugs.kde.org/show_bug.cgi?id=189456
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Since KSMServer does the session teardown, we can't just rely on Logind's \
> PreparingForShutdown property.
> This patch will allow for instance PowerDevil to not suspend the session when it's \
> currently shutting down, otherwise you'll have your system suspend and continue \
> shutting down after resuming.
>
> Diffs
> -----
>
> ksmserver/shutdown.cpp e6bc708
> libkworkspace/kworkspace.h 816f8f1
> libkworkspace/kworkspace.cpp ac979bd
> ksmserver/org.kde.KSMServerInterface.xml 9dad130
> ksmserver/server.h 20b5faa
>
> Diff: https://git.reviewboard.kde.org/r/122339/diff/
>
>
> Testing
> -------
>
> Works, adjusted PowerDevil and the system did not suspend during shutdown.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============5688498902343980945==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122339/">https://git.reviewboard.kde.org/r/122339/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">is \
that for the case that no logind is used? Or should ksmserver better integrate with \
logind?</p></pre> <br />
<p>- Martin Gräßlin</p>
<br />
<p>On January 31st, 2015, 5:02 p.m. CET, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Martin Gräßlin.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Jan. 31, 2015, 5:02 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=189456">189456</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Since KSMServer does the session teardown, we can't \
just rely on Logind's PreparingForShutdown property.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
patch will allow for instance PowerDevil to not suspend the session when it's \
currently shutting down, otherwise you'll have your system suspend and continue \
shutting down after resuming.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works, adjusted PowerDevil and the system did not \
suspend during shutdown.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/shutdown.cpp <span style="color: grey">(e6bc708)</span></li>
<li>libkworkspace/kworkspace.h <span style="color: grey">(816f8f1)</span></li>
<li>libkworkspace/kworkspace.cpp <span style="color: grey">(ac979bd)</span></li>
<li>ksmserver/org.kde.KSMServerInterface.xml <span style="color: \
grey">(9dad130)</span></li>
<li>ksmserver/server.h <span style="color: grey">(20b5faa)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122339/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5688498902343980945==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic