[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 122332: KQuickControls IconDialog
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2015-01-31 23:58:29
Message-ID: 20150131235829.13680.55908 () probe ! kde ! org
[Download RAW message or body]
--===============7889490327269793990==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
On Jan. 31, 2015, 3:41 a.m., Kai Uwe Broulik wrote:
> > I told you previously but I think you missed it, we have \
> > PlasmaPlatformComponents.IconDialog, so lets not reinvent wheel. it is already \
> > used by activity manager
We cannot at the same time tell people Plasma components and app components should be \
visually different; and at the same time tell developers they should be using some \
stuff from plasma in their apps. They're not compatiable plans.
Also this is a /lot lot/ better than the implementation in PlatformComponents. It's \
similar to the approach QtQuick.Dialogs; you return a QObject with properties. For \
now that wraps a QWidget dialog in the desktop mode for now; but it could just as \
easily return something a QWindow QML item with QtQuick Controls inside in future \
without breaking API. (much)
It might be re-inventing a wheel, but it's adding a rubber tyre on the outside whilst \
it does it.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122332/#review75062
-----------------------------------------------------------
On Jan. 30, 2015, 10:07 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122332/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2015, 10:07 p.m.)
>
>
> Review request for Plasma and Daniel Vrátil.
>
>
> Repository: kdeclarative
>
>
> Description
> -------
>
> This patch adds KQuickControls wrapper around KIconDialog similar to how the \
> ColorDialog and other QtQuick Dialogs work. This can be used, for instance, in \
> Kickoff's config UI to provide a picker for a custom item.
> It is an initial draft and lacks for example window modality as I couldn't figure \
> out how QtQuick Dialogs do that (some PlatformDialogHelper magic inside) and I'm \
> also not sure about the lifecycle/ownership of the dialog, I've seen a lot of fixes \
> for issues in that area on Review Board.
>
> Diffs
> -----
>
> src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 65e28ff
> src/qmlcontrols/kquickcontrolsaddons/icondialog.h PRE-CREATION
> src/qmlcontrols/kquickcontrolsaddons/icondialog.cpp PRE-CREATION
> src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp 289f1ed
>
> Diff: https://git.reviewboard.kde.org/r/122332/diff/
>
>
> Testing
> -------
>
> For testing I added a button to Kickoff that allows to open the dialog and the \
> button icon source is bound to the dialog's iconName property. Didn't test the icon \
> source/user/custom path stuff.
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============7889490327269793990==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122332/">https://git.reviewboard.kde.org/r/122332/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 31st, 2015, 3:41 a.m. UTC, <b>Bhushan \
Shah</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I told you previously but I think you missed it, we \
have PlasmaPlatformComponents.IconDialog, so lets not reinvent wheel. it is already \
used by activity manager</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We \
cannot at the same time tell people Plasma components and app components should be \
visually different; and at the same time tell developers they should be using some \
stuff from plasma in their apps. They're not compatiable plans.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Also this is a /lot lot/ better than the implementation in \
PlatformComponents. It's similar to the approach QtQuick.Dialogs; you return a \
QObject with properties. For now that wraps a QWidget dialog in the desktop mode for \
now; but it could just as easily return something a QWindow QML item with QtQuick \
Controls inside in future without breaking API. (much)</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It \
might be re-inventing a wheel, but it's adding a rubber tyre on the outside whilst it \
does it.</p></pre> <br />
<p>- David</p>
<br />
<p>On January 30th, 2015, 10:07 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Daniel Vrátil.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Jan. 30, 2015, 10:07 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeclarative
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch adds KQuickControls wrapper around \
KIconDialog similar to how the ColorDialog and other QtQuick Dialogs work. This can \
be used, for instance, in Kickoff's config UI to provide a picker for a custom \
item.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It is an initial draft and lacks for example window \
modality as I couldn't figure out how QtQuick Dialogs do that (some \
PlatformDialogHelper magic inside) and I'm also not sure about the \
lifecycle/ownership of the dialog, I've seen a lot of fixes for issues in that area \
on Review Board.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">For testing I added a button to Kickoff that allows to \
open the dialog and the button icon source is bound to the dialog's iconName \
property. Didn't test the icon source/user/custom path stuff.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt <span style="color: \
grey">(65e28ff)</span></li>
<li>src/qmlcontrols/kquickcontrolsaddons/icondialog.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/qmlcontrols/kquickcontrolsaddons/icondialog.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp <span \
style="color: grey">(289f1ed)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122332/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7889490327269793990==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic