[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 122257: Fix maximized window menu button position.
From: "Xuetian Weng" <wengxt () gmail ! com>
Date: 2015-01-30 17:58:51
Message-ID: 20150130175851.13679.32166 () probe ! kde ! org
[Download RAW message or body]
--===============4480737377469852834==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122257/
-----------------------------------------------------------
(Updated Jan. 30, 2015, 5:58 p.m.)
Status
------
This change has been discarded.
Review request for Plasma and Hugo Pereira Da Costa.
Repository: breeze
Description
-------
See screen shot.
Diffs
-----
kdecoration/breezebutton.cpp 25aa273
Diff: https://git.reviewboard.kde.org/r/122257/diff/
Testing
-------
maximized window and normal window have same menu icon position.
File Attachments
----------------
after
https://git.reviewboard.kde.org/media/uploaded/files/2015/01/26/7ceb478c-5c36-4caa-8da2-102b99f5e1e2__screenshot1.png
before
https://git.reviewboard.kde.org/media/uploaded/files/2015/01/26/67ea38ed-97c6-4706-9402-c79737e925a3__screenshot2.png
Thanks,
Xuetian Weng
--===============4480737377469852834==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122257/">https://git.reviewboard.kde.org/r/122257/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Hugo Pereira Da Costa.</div>
<div>By Xuetian Weng.</div>
<p style="color: grey;"><i>Updated Jan. 30, 2015, 5:58 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
breeze
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">See screen shot.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">maximized window and normal window have same menu icon \
position.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecoration/breezebutton.cpp <span style="color: grey">(25aa273)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122257/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/01/26/7ceb478c-5c36-4caa-8da2-102b99f5e1e2__screenshot1.png">after</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/01/26/67ea38ed-97c6-4706-9402-c79737e925a3__screenshot2.png">before</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4480737377469852834==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic