[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 122328: Fix apply button in breeze window decoration config
From: Pinak Ahuja <pinak.ahuja () gmail ! com>
Date: 2015-01-30 12:58:07
Message-ID: CAAbh0gBynuWG2V-D_c+w_5VkODHm9uCtJRwn7w-vtAnSp-ZCwg () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Commit to master right?
On 30 Jan 2015 17:38, "Hugo Pereira Da Costa" <hugo.pereira@free.fr> wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122328/
>
> On January 30th, 2015, 12:01 p.m. UTC, *Hugo Pereira Da Costa* wrote:
>
> Ship It!
>
> PS: do you have commit access ? Otherwise I can commit for you.
>
>
> - Hugo
>
> On January 30th, 2015, 11:42 a.m. UTC, Pinak Ahuja wrote:
> Review request for Plasma and Hugo Pereira Da Costa.
> By Pinak Ahuja.
>
> *Updated Jan. 30, 2015, 11:42 a.m.*
> *Repository: * breeze
> Description
>
> The apply button in breeze's config in windows decoration kcm wasn't becoming \
> active on changing the config. This fixes its behaviour.
> Testing
>
> Compiled and installed, apply button works as expected.
>
> Diffs
>
> - kdecoration/config/breezeconfigwidget.cpp (e160c57)
>
> View Diff <https://git.reviewboard.kde.org/r/122328/diff/>
>
[Attachment #5 (text/html)]
<p dir="ltr">Commit to master right?</p>
<div class="gmail_quote">On 30 Jan 2015 17:38, "Hugo Pereira Da Costa" \
<<a href="mailto:hugo.pereira@free.fr">hugo.pereira@free.fr</a>> wrote:<br \
type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border:1px #c9c399 \
solid;border-radius:6px"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122328/" \
target="_blank">https://git.reviewboard.kde.org/r/122328/</a> </td>
</tr>
</table>
<br>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<p style="margin-top:0">On January 30th, 2015, 12:01 p.m. UTC, <b>Hugo Pereira Da \
Costa</b> wrote:</p> <blockquote style="margin-left:1em;border-left:2px solid \
#d0d0d0;padding-left:10px"> <pre \
style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p \
style="padding:0;margin:0;line-height:inherit;white-space:inherit">Ship It!</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p \
style="padding:0;margin:0;line-height:inherit;white-space:inherit">PS: do you have \
commit access ? Otherwise I can commit for you.</p></pre> <br>
<p>- Hugo</p>
<br>
<p>On January 30th, 2015, 11:42 a.m. UTC, Pinak Ahuja wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" \
style="border:1px #888a85 solid;border-radius:6px"> <tr>
<td>
<div>Review request for Plasma and Hugo Pereira Da Costa.</div>
<div>By Pinak Ahuja.</div>
<p style="color:grey"><i>Updated Jan. 30, 2015, 11:42 a.m.</i></p>
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt">Repository: </b>
breeze
</div>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border:1px solid #b8b5a0"> <tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p \
style="padding:0;margin:0;line-height:inherit;white-space:inherit">The apply button \
in breeze's config in windows decoration kcm wasn't becoming active on \
changing the config. This fixes its behaviour.</p></pre> </td>
</tr>
</table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border:1px solid #b8b5a0"> <tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p \
style="padding:0;margin:0;line-height:inherit;white-space:inherit">Compiled and \
installed, apply button works as expected.</p></pre> </td>
</tr>
</table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>kdecoration/config/breezeconfigwidget.cpp <span \
style="color:grey">(e160c57)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122328/diff/" style="margin-left:3em" \
target="_blank">View Diff</a></p>
</td>
</tr>
</table>
</div>
</div>
</blockquote></div>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic