[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 122328: Fix apply button in breeze window decoration config
From:       Hugo Pereira Da Costa <hugo.pereira () free ! fr>
Date:       2015-01-30 12:02:50
Message-ID: 54CB72EA.1060604 () free ! fr
[Download RAW message or body]

On 01/30/2015 12:58 PM, Pinak Ahuja wrote:
>
> I might be wrong, but shouldn't the changed signal have a bool 
> parameter? The changed() without a parameter refers to a slot(can we 
> emit a slot? I'm new to this). I didn't compile and check if the 
> behaviour was fixed in the master branch without this patch, I have 
> the problem with the plasma 5.2 package shipped with arch Linux.
>
ok. You're right, my bad. (even if I'm still not sure why it fixes the 
issue, the change is definitly correct)

Just sent a chip-it

Thanks !

Hugo
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]