[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 122319: Set global shortcuts for touchpad enable/disable/toggle
From: "Martin Klapetek" <martin.klapetek () gmail ! com>
Date: 2015-01-29 23:10:58
Message-ID: 20150129231058.13679.16594 () probe ! kde ! org
[Download RAW message or body]
--===============0094567649289557692==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122319/#review75012
-----------------------------------------------------------
src/kded/kdedactions.cpp
<https://git.reviewboard.kde.org/r/122319/#comment51940>
Use qWarning rather than qDebug, I'd say it's a warning after all...
src/kded/kdedactions.cpp
<https://git.reviewboard.kde.org/r/122319/#comment51941>
If this is not needed anymore, just remove it altogether
- Martin Klapetek
On Jan. 29, 2015, 11:56 p.m., Rajeesh K Nambiar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122319/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2015, 11:56 p.m.)
>
>
> Review request for Plasma, Alexander Mezin and Jonathan Riddell.
>
>
> Bugs: 342629
> http://bugs.kde.org/show_bug.cgi?id=342629
>
>
> Repository: kcm-touchpad
>
>
> Description
> -------
>
> Set global shortcuts for touchpad enable/disable/toggle.
> Review and comments welcome.
> Bug 342629
>
>
> Diffs
> -----
>
> src/kded/kdedactions.cpp ca32834
>
> Diff: https://git.reviewboard.kde.org/r/122319/diff/
>
>
> Testing
> -------
>
> Build Fedora RPMS against Plasma 5.2, default global shortcuts for touchpad are \
> set.
>
> Thanks,
>
> Rajeesh K Nambiar
>
>
--===============0094567649289557692==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122319/">https://git.reviewboard.kde.org/r/122319/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/122319/diff/1/?file=345722#file345722line38" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/kded/kdedactions.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">TouchpadGlobalActions::TouchpadGlobalActions(bool isConfiguration, QObject \
*parent)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">38</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="n">qDebug</span><span \
class="p">()</span> <span class="o"><<</span> <span \
class="s">"Couldn't set global shortcut to Qt::Key_TouchpadOn. There's \
another program using it, otherwise file a bug against kcm_touchpad"</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Use \
qWarning rather than qDebug, I'd say it's a warning after all...</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/122319/diff/1/?file=345722#file345722line58" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/kded/kdedactions.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">TouchpadGlobalActions::TouchpadGlobalActions(bool isConfiguration, QObject \
*parent)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">46</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KGlobalAccel</span><span class="o">::</span><span \
class="n">setGlobalShortcut</span><span class="p">(</span><span \
class="n">act</span><span class="p">,</span><span class="n">QKeySequence</span><span \
class="p">());</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">58</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="c1"><span \
class="hl">//</span>KGlobalAccel::setGlobalShortcut(act,QKeySequence());</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If \
this is not needed anymore, just remove it altogether</p></pre> </div>
</div>
<br />
<p>- Martin Klapetek</p>
<br />
<p>On January 29th, 2015, 11:56 p.m. CET, Rajeesh K Nambiar wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, Alexander Mezin and Jonathan Riddell.</div>
<div>By Rajeesh K Nambiar.</div>
<p style="color: grey;"><i>Updated Jan. 29, 2015, 11:56 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=342629">342629</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcm-touchpad
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Set global shortcuts for touchpad \
enable/disable/toggle. Review and comments welcome.
Bug 342629</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Build Fedora RPMS against Plasma 5.2, default global \
shortcuts for touchpad are set.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kded/kdedactions.cpp <span style="color: grey">(ca32834)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122319/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0094567649289557692==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic