'Re: Review Request 122319: Set global shortcuts for touchpad enable/disable/toggle'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 122319: Set global shortcuts for touchpad enable/disable/toggle
From:       "Rajeesh K Nambiar" <rajeeshknambiar () gmail ! com>
Date:       2015-01-29 23:09:43
Message-ID: 20150129230943.13679.89258 () probe ! kde ! org
[Download RAW message or body]

--===============8927938504632446975==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On Jan. 29, 2015, 11:07 p.m., Lukáš Tinkl wrote:
> > Ship It!

That was quick! :-)
I don't have commit access - could you commit please?

- Rajeesh

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122319/#review75010
-----------------------------------------------------------

On Jan. 29, 2015, 10:56 p.m., Rajeesh K Nambiar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122319/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2015, 10:56 p.m.)
> 
> 
> Review request for Plasma, Alexander Mezin and Jonathan Riddell.
> 
> 
> Bugs: 342629
> http://bugs.kde.org/show_bug.cgi?id=342629
> 
> 
> Repository: kcm-touchpad
> 
> 
> Description
> -------
> 
> Set global shortcuts for touchpad enable/disable/toggle.
> Review and comments welcome.
> Bug 342629
> 
> 
> Diffs
> -----
> 
> src/kded/kdedactions.cpp ca32834 
> 
> Diff: https://git.reviewboard.kde.org/r/122319/diff/
> 
> 
> Testing
> -------
> 
> Build Fedora RPMS against Plasma 5.2, default global shortcuts for touchpad are \
> set. 
> 
> Thanks,
> 
> Rajeesh K Nambiar
> 
> 

--===============8927938504632446975==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122319/">https://git.reviewboard.kde.org/r/122319/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On January 29th, 2015, 11:07 p.m. UTC, <b>Lukáš \
Tinkl</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Ship It!</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That \
was quick! :-) I don't have commit access - could you commit please?</p></pre>
<br />

<p>- Rajeesh</p>

<br />
<p>On January 29th, 2015, 10:56 p.m. UTC, Rajeesh K Nambiar wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma, Alexander Mezin and Jonathan Riddell.</div>
<div>By Rajeesh K Nambiar.</div>

<p style="color: grey;"><i>Updated Jan. 29, 2015, 10:56 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=342629">342629</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kcm-touchpad
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Set global shortcuts for touchpad \
enable/disable/toggle. Review and comments welcome.
Bug 342629</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Build Fedora RPMS against Plasma 5.2, default global \
shortcuts for touchpad are set.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kded/kdedactions.cpp <span style="color: grey">(ca32834)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122319/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8927938504632446975==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 