'Re: Review Request 120040: Install kdesu under bin'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 120040: Install kdesu under bin
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2015-01-29 15:16:12
Message-ID: 20150129151612.13679.58936 () probe ! kde ! org
[Download RAW message or body]

--===============4519529152997796618==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120040/
-----------------------------------------------------------

(Updated Jan. 29, 2015, 3:16 p.m.)

Status
------

This change has been discarded.

Review request for KDE Frameworks and Plasma.

Repository: kde-cli-tools

Description
-------

this is a part of adressing the bug
https://bugs.kde.org/show_bug.cgi?id=338755
https://bugs.kde.org/show_bug.cgi?id=338756

in kde4 kdesu was installed under bin, and should still, being something that should \
be invokable  but renames it to kdesu5, for coinstallability reasons

therefore, kio/src/core/desktopexecparser.cpp should be modified to search for kdesu5 \
instead of kdesu

Diffs
-----

  kdesu/CMakeLists.txt 2a70831 

Diff: https://git.reviewboard.kde.org/r/120040/diff/

Testing
-------

Thanks,

Marco Martin

--===============4519529152997796618==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120040/">https://git.reviewboard.kde.org/r/120040/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Marco Martin.</div>

<p style="color: grey;"><i>Updated Jan. 29, 2015, 3:16 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-cli-tools
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">this is a part of adressing the bug \
https://bugs.kde.org/show_bug.cgi?id=338755 \
https://bugs.kde.org/show_bug.cgi?id=338756</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">in kde4 kdesu was \
installed under bin, and should still, being something that should be invokable  but \
renames it to kdesu5, for coinstallability reasons</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">therefore, kio/src/core/desktopexecparser.cpp should be modified to search \
for kdesu5 instead of kdesu</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kdesu/CMakeLists.txt <span style="color: grey">(2a70831)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120040/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4519529152997796618==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 