'Re: Review Request 122304: qtquickcontrols: Implement an ApplicationWindowStyle stub.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 122304: qtquickcontrols: Implement an ApplicationWindowStyle stub.
From:       "Nikita Skovoroda" <chalkerx () gmail ! com>
Date:       2015-01-29 9:54:13
Message-ID: 20150129095413.30979.97966 () probe ! kde ! org
[Download RAW message or body]

--===============3851175214200034425==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122304/
-----------------------------------------------------------

(Updated Jan. 29, 2015, 9:54 a.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma, Andrew Lake and Marco Martin.

Repository: breeze

Description
-------

This commit adds a stub implementing ApplicationWindowStyle.
This is required for qml applications to automatically use SystemPallete background \
color instead of a white one when launched with QT_QUICK_CONTROLS_STYLE=Breeze. \
Borders etc. are not altered, this just loads the default ApplicationWindowStyle \
implementation.

Diffs
-----

  qtquickcontrols/ApplicationWindowStyle.qml PRE-CREATION 
  qtquickcontrols/Breeze.qml df27579 
  qtquickcontrols/qmldir 685e763 

Diff: https://git.reviewboard.kde.org/r/122304/diff/

Testing
-------

Works for me, fixes background for qml applications that are using \
ApplicationWindow{}.

Thanks,

Nikita Skovoroda

--===============3851175214200034425==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122304/">https://git.reviewboard.kde.org/r/122304/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma, Andrew Lake and Marco Martin.</div>
<div>By Nikita Skovoroda.</div>

<p style="color: grey;"><i>Updated Jan. 29, 2015, 9:54 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
breeze
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This commit adds a stub implementing \
ApplicationWindowStyle. This is required for qml applications to automatically use \
SystemPallete background color instead of a white one when launched with \
QT_QUICK_CONTROLS_STYLE=Breeze. Borders etc. are not altered, this just loads the \
default ApplicationWindowStyle implementation.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works for me, fixes background for qml applications \
that are using ApplicationWindow{}.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>qtquickcontrols/ApplicationWindowStyle.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>qtquickcontrols/Breeze.qml <span style="color: grey">(df27579)</span></li>

 <li>qtquickcontrols/qmldir <span style="color: grey">(685e763)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122304/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3851175214200034425==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 