[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 122209: [plasma-workspace] Make tests optional
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2015-01-28 14:35:45
Message-ID: 20150128143545.30683.27385 () probe ! kde ! org
[Download RAW message or body]
--===============2494197337642905313==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122209/#review74914
-----------------------------------------------------------
Ship it!
Ship It!
- David Edmundson
On Jan. 22, 2015, 9:43 p.m., Andreas Sturmlechner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122209/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2015, 9:43 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Qt5Test should not be mandatory. The patch moves find_package(Qt5Test...) out of \
> CMakeLists.txt and adds drkonqi/internalkxmlrpcclient/autotests only \
> if(BUILD_TESTING).
> I do not have write access.
>
>
> Diffs
> -----
>
> CMakeLists.txt e4d2b2dcf25ce7892f63c0279cea99329ec4b5f4
> drkonqi/internalkxmlrpcclient/CMakeLists.txt \
> 276aeaaa0b058fa38d44dd52bd5b93f2b839d6f8
> Diff: https://git.reviewboard.kde.org/r/122209/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andreas Sturmlechner
>
>
--===============2494197337642905313==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122209/">https://git.reviewboard.kde.org/r/122209/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship \
It!</p></pre> <br />
<p>- David Edmundson</p>
<br />
<p>On January 22nd, 2015, 9:43 p.m. UTC, Andreas Sturmlechner wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Andreas Sturmlechner.</div>
<p style="color: grey;"><i>Updated Jan. 22, 2015, 9:43 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Qt5Test should not be mandatory. The patch moves \
find_package(Qt5Test...) out of CMakeLists.txt and adds \
drkonqi/internalkxmlrpcclient/autotests only if(BUILD_TESTING).</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I do not have write access.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(e4d2b2dcf25ce7892f63c0279cea99329ec4b5f4)</span></li>
<li>drkonqi/internalkxmlrpcclient/CMakeLists.txt <span style="color: \
grey">(276aeaaa0b058fa38d44dd52bd5b93f2b839d6f8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122209/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2494197337642905313==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic