'Re: Review Request 122065: Fix activity start and stop.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 122065: Fix activity start and stop.
From:       Ivan Čukić <ivan.cukic () kde ! org>
Date:       2015-01-27 16:25:09
Message-ID: 20150127162509.30682.44693 () probe ! kde ! org
[Download RAW message or body]

--===============0034377137207610807==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122065/#review74835
-----------------------------------------------------------

Ship it!

Ship It!

- Ivan Čukić

On Jan. 27, 2015, 4:18 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122065/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2015, 4:18 p.m.)
> 
> 
> Review request for Plasma, Martin Gräßlin and Ivan Čukić.
> 
> 
> Repository: kactivities
> 
> 
> Description
> -------
> 
> 1. KWin Interface name is wrong
> 2. kactivitymanagerd doesn't listen on ksmserver anymore, thus \
> subSession{Opened,Closed,CloseCanceled} are not called anymore. It need to send \
> Started/Stopped event by itself when kwin dbus call returns. 
> 
> Diffs
> -----
> 
> src/service/ksmserver/KSMServer.cpp b5e1467 
> src/service/ksmserver/KSMServer_p.h c0f5598 
> 
> Diff: https://git.reviewboard.kde.org/r/122065/diff/
> 
> 
> Testing
> -------
> 
> Now starting and stopping activity works properly.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
> 

--===============0034377137207610807==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122065/">https://git.reviewboard.kde.org/r/122065/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship \
It!</p></pre>  <br />

<p>- Ivan Čukić</p>

<br />
<p>On January 27th, 2015, 4:18 p.m. UTC, Xuetian Weng wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma, Martin Gräßlin and Ivan Čukić.</div>
<div>By Xuetian Weng.</div>

<p style="color: grey;"><i>Updated Jan. 27, 2015, 4:18 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kactivities
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
2em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">KWin Interface name is \
wrong</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">kactivitymanagerd doesn't listen on ksmserver anymore, \
thus subSession{Opened,Closed,CloseCanceled} are not called anymore. It need to send \
Started/Stopped event by itself when kwin dbus call returns.</li> </ol></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Now starting and stopping activity works \
properly.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/service/ksmserver/KSMServer.cpp <span style="color: \
grey">(b5e1467)</span></li>

 <li>src/service/ksmserver/KSMServer_p.h <span style="color: \
grey">(c0f5598)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122065/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0034377137207610807==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 