[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: [plasma-workspace] startkde/kcminit: qstring optimization, use qset to avoid n^2 complexity
From:       Christoph Feck <cfeck () kde ! org>
Date:       2015-01-27 3:27:17
Message-ID: 201501270427.17779.cfeck () kde ! org
[Download RAW message or body]

On Tuesday 27 January 2015 02:47:52 Nick Shaforostoff wrote:
> Git commit a5d47846f572b325057627efc9b5d920fa34ca64 by Nick
> Shaforostoff. Committed on 27/01/2015 at 03:47.
> Pushed by shaforo into branch 'master'.
> 
> qstring optimization, use qset to avoid n^2 complexity
> [...]
> +    QString KCMINIT_PREFIX=QStringLiteral("kcminit_");

Hi Nick,
can you please use review requests for code changes? Having multiple 
eyes is beneficial for code quality. For example, this line misses 
spaces around the binary operator, and we do not like making separate 
commits just to fix white space errors.

Thanks,
Christoph Feck (kdepepo)
KDE Quality Team
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]