[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2015-01-25 16:09:26
Message-ID: 20150125160926.30682.29134 () probe ! kde ! org
[Download RAW message or body]
--===============8832854913127139013==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122239/#review74709
-----------------------------------------------------------
+1 to the idea
src/qmlcontrols/kquickcontrolsaddons/kcmshell.cpp
<https://git.reviewboard.kde.org/r/122239/#comment51785>
given we can open multiple modules it would be good to expose setting
--caption and --icon
-
to kcmshell
otherwise it just takes the name of first one plus "KDE Control Module" which is \
a bit messy.
Shouldn't we be using KService here?
- David Edmundson
On Jan. 24, 2015, 11:54 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122239/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2015, 11:54 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: kdeclarative
>
>
> Description
> -------
>
> Since there are already like 10 copies of the ProcessRunner for all kinds of \
> plasmoids wanting to open a KCM, this adds a KCMShell.open("foo") and \
> KCMShell.open(["foo", "bar", "baz"]) singleton.
>
> Diffs
> -----
>
> src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 65e28ff
> src/qmlcontrols/kquickcontrolsaddons/kcmshell.h PRE-CREATION
> src/qmlcontrols/kquickcontrolsaddons/kcmshell.cpp PRE-CREATION
> src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp 289f1ed
>
> Diff: https://git.reviewboard.kde.org/r/122239/diff/
>
>
> Testing
> -------
>
> Works. Dunno if the name causes clashes or this is the right place to put it.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============8832854913127139013==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122239/">https://git.reviewboard.kde.org/r/122239/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1 to \
the idea</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/122239/diff/2/?file=344639#file344639line36" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/qmlcontrols/kquickcontrolsaddons/kcmshell.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">36</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QProcess</span><span class="o">::</span><span \
class="n">startDetached</span><span class="p">(</span><span \
class="n">QStringLiteral</span><span class="p">(</span><span \
class="s">"kcmshell5"</span><span class="p">),</span> <span \
class="n">names</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">given \
we can open multiple modules it would be good to expose setting</p> <h2 \
style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">--caption and --icon</h2> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">to \
kcmshell</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">otherwise it just takes the name of first one plus \
"KDE Control Module" which is a bit messy.</p></pre> </div>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Shouldn't we be using KService here?</p></pre>
<p>- David Edmundson</p>
<br />
<p>On January 24th, 2015, 11:54 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Jan. 24, 2015, 11:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeclarative
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Since there are already like 10 copies of the \
ProcessRunner for all kinds of plasmoids wanting to open a KCM, this adds a \
KCMShell.open("foo") and KCMShell.open(["foo", "bar", "baz"]) singleton.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works. Dunno if the name causes clashes or this is the \
right place to put it.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt <span style="color: \
grey">(65e28ff)</span></li>
<li>src/qmlcontrols/kquickcontrolsaddons/kcmshell.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/qmlcontrols/kquickcontrolsaddons/kcmshell.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp <span \
style="color: grey">(289f1ed)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122239/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8832854913127139013==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic