'Re: Review Request 122171: Implement SystemTrayMenuItem::setMenu() correctly.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 122171: Implement SystemTrayMenuItem::setMenu() correctly.
From:       "Dmitry Shachnev" <mitya57 () gmail ! com>
Date:       2015-01-22 16:09:39
Message-ID: 20150122160939.32443.68809 () probe ! kde ! org
[Download RAW message or body]

--===============5090509043909033263==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On Jan. 20, 2015, 3:46 nachm., Marco Martin wrote:
> > Ship It!
> 
> Dmitry Shachnev wrote:
> I will need someone to push it for me, but first I want to get the meteo-qt \
> developer to test it (I have sent him a link), wait until that please.

Ok, I tested it myself on another machine, and the fix work there as well (after \
applying the needed Qt change).

Please go ahead and submit this.

- Dmitry

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122171/#review74397
-----------------------------------------------------------

On Jan. 20, 2015, 3:40 nachm., Dmitry Shachnev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122171/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2015, 3:40 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> Implement SystemTrayMenuItem::setMenu() correctly.
> 
> We need to actually set the action menu, not just store it somewhere, to make \
> submenus in tray icons working. 
> 
> Diffs
> -----
> 
> src/platformtheme/kdeplatformsystemtrayicon.h 3c1bbf7 
> src/platformtheme/kdeplatformsystemtrayicon.cpp d3a1d4f 
> 
> Diff: https://git.reviewboard.kde.org/r/122171/diff/
> 
> 
> Testing
> -------
> 
> Tested this app: https://github.com/dglent/meteo-qt
> 
> 
> Thanks,
> 
> Dmitry Shachnev
> 
> 

--===============5090509043909033263==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122171/">https://git.reviewboard.kde.org/r/122171/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On Januar 20th, 2015, 3:46 nachm. UTC, <b>Marco \
Martin</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Ship It!</p></pre>  </blockquote>

 <p>On Januar 20th, 2015, 3:48 nachm. UTC, <b>Dmitry Shachnev</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
will need someone to push it for me, but first I want to get the meteo-qt developer \
to test it (I have sent him a link), wait until that please.</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ok, I \
tested it myself on another machine, and the fix work there as well (after applying \
the needed Qt change).</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Please go ahead and submit \
this.</p></pre> <br />

<p>- Dmitry</p>

<br />
<p>On Januar 20th, 2015, 3:40 nachm. UTC, Dmitry Shachnev wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Dmitry Shachnev.</div>

<p style="color: grey;"><i>Updated Jan. 20, 2015, 3:40 nachm.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
frameworkintegration
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Implement SystemTrayMenuItem::setMenu() correctly.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">We need to actually set the action menu, not just \
store it somewhere, to make submenus in tray icons working.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested this app: \
https://github.com/dglent/meteo-qt</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/platformtheme/kdeplatformsystemtrayicon.h <span style="color: \
grey">(3c1bbf7)</span></li>

 <li>src/platformtheme/kdeplatformsystemtrayicon.cpp <span style="color: \
grey">(d3a1d4f)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122171/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5090509043909033263==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 