[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 121718: Allow to compile plasma-workspace without Qt5WebKit installed.
From: "Bhushan Shah" <bhush94 () gmail ! com>
Date: 2015-01-06 12:00:38
Message-ID: 20150106120038.15695.54253 () probe ! kde ! org
[Download RAW message or body]
--===============6021929849681281985==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Jan. 6, 2015, 3:07 p.m., Kai Uwe Broulik wrote:
> > CMakeLists.txt, line 13
> > <https://git.reviewboard.kde.org/r/121718/diff/2/?file=338299#file338299line13>
> >
> > My CMake complains about this:
> > Unknown CMake command "set_package_properties".
Fixed in http://commits.kde.org/plasma-workspace/0d354bea0e7bab8ab97896cef68fd1f4ccfb286b
- Bhushan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121718/#review73246
-----------------------------------------------------------
On Jan. 6, 2015, 1:27 p.m., David Faure wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121718/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2015, 1:27 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Only drkonqi and systemmonitor depend on it.
>
> (systemmonitor uses libksysguard's processui lib, which is not installed
> by libksysguard if webkit is not found)
>
> REVIEW: 121718
>
>
> Diffs
> -----
>
> CMakeLists.txt c6d89c14b05f5639937aee5692d305fa2faed974
> drkonqi/CMakeLists.txt a362d7ec651c027d91d0912e84817cd3a2f94d67
>
> Diff: https://git.reviewboard.kde.org/r/121718/diff/
>
>
> Testing
> -------
>
> Compiling without qt5 webkit.
>
>
> Thanks,
>
> David Faure
>
>
--===============6021929849681281985==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121718/">https://git.reviewboard.kde.org/r/121718/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 6th, 2015, 3:07 p.m. IST, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/121718/diff/2/?file=338299#file338299line13" \
style="color: black; font-weight: bold; text-decoration: \
underline;">CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">13</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">set_package_properties</span><span class="p">(</span><span \
class="s">Qt5WebKitWidgets</span> <span class="s">PROPERTIES</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">My \
CMake complains about this: Unknown CMake command \
"set_package_properties".</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Fixed in http://commits.kde.org/plasma-workspace/0d354bea0e7bab8ab97896cef68fd1f4ccfb286b</p></pre>
<br />
<p>- Bhushan</p>
<br />
<p>On January 6th, 2015, 1:27 p.m. IST, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated Jan. 6, 2015, 1:27 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Only drkonqi and systemmonitor depend on it.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">(systemmonitor uses libksysguard's processui lib, which is not installed by \
libksysguard if webkit is not found)</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">REVIEW: \
121718</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compiling without qt5 webkit.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(c6d89c14b05f5639937aee5692d305fa2faed974)</span></li>
<li>drkonqi/CMakeLists.txt <span style="color: \
grey">(a362d7ec651c027d91d0912e84817cd3a2f94d67)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121718/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6021929849681281985==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic