[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 120276: Initial port to frameworks for the comic dataengine.
From: "Andrei Amuraritei" <sirdeiu () bydeiu ! net>
Date: 2015-01-03 6:20:27
Message-ID: 20150103062027.30560.79404 () probe ! kde ! org
[Download RAW message or body]
--===============8988079560959204176==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Dec. 11, 2014, 12:24 p.m., Marco Martin wrote:
> > what's the status of this?
>
> Andrei Amuraritei wrote:
> Hi there, this compiles and works, as best I could test it. Still needs work to \
> port away from kde4support libs. Sadly my time with it has been null, too busy with \
> work and other stuff still.
> Marco Martin wrote:
> can you push your work so far in a git branch? so is easy for people to try, and \
> eventually contribute ;)
> David Edmundson wrote:
> As there has been no reply, I'm going to push this into master but leave the \
> dataengine commented out in the CMakeLists.txt. There's no point shipping it till \
> the plasmoid is done.
> To me the diff looks OK. Clearly a bit of work left, but what is here seems good.
Sorry for not replying sooner, but I guess David did the better thing here. The \
engine works and I guess if people do really want to work on it (I still do), now \
they'll do it easier. On my part, I still need to get hold of the whole "devel" \
phase, so I'm slower.
Thanks David. And Happy New Year to you all.
- Andrei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120276/#review71785
-----------------------------------------------------------
On Jan. 2, 2015, 1:30 p.m., Andrei Amuraritei wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120276/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2015, 1:30 p.m.)
>
>
> Review request for Plasma, David Edmundson, Marco Martin, Martin Klapetek, and \
> Sebastian Kügler.
>
> Repository: kdeplasma-addons
>
>
> Description
> -------
>
> comic DataEngine initial port to frameworks.
>
>
> Diffs
> -----
>
> dataengines/CMakeLists.txt 04c7985
> dataengines/comic/CMakeLists.txt 8e382e6
> dataengines/comic/cachedprovider.h baac8a9
> dataengines/comic/cachedprovider.cpp caca25e
> dataengines/comic/comic.h 8cc3969
> dataengines/comic/comic.cpp 7130f44
> dataengines/comic/comic_package.h 32be381
> dataengines/comic/comic_package.cpp 6d2ff0b
> dataengines/comic/comic_package_plugin.cpp d997947
> dataengines/comic/comicprovider.h 630ee8d
> dataengines/comic/comicprovider.cpp ab248a5
> dataengines/comic/comicproviderkross.h 46a9072
> dataengines/comic/comicproviderkross.cpp 9820f05
> dataengines/comic/comicproviderwrapper.h 81eee68
> dataengines/comic/comicproviderwrapper.cpp 48ced42
>
> Diff: https://git.reviewboard.kde.org/r/120276/diff/
>
>
> Testing
> -------
>
> Building from source, compiles 100%, some deprecated warnings. DataEngine shows up \
> in plasmaengineexplorer and detects installed .comic packages. This is the initial \
> port, still need to review code to fix issues like whitespaces around ( or the \
> deprecated parts. Thanks notmart, d_ed, sebas, bshas etc for helping.
>
> Update: Engine is working...still need to port away from Solid and KService to \
> remove KDELibs4Support, that is still wip.
>
> Thanks,
>
> Andrei Amuraritei
>
>
--===============8988079560959204176==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120276/">https://git.reviewboard.kde.org/r/120276/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 11th, 2014, 12:24 p.m. EET, <b>Marco \
Martin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">what's the status of this?</p></pre> </blockquote>
<p>On December 13th, 2014, 3:07 p.m. EET, <b>Andrei Amuraritei</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi \
there, this compiles and works, as best I could test it. Still needs work to port \
away from kde4support libs. Sadly my time with it has been null, too busy with work \
and other stuff still.</p></pre> </blockquote>
<p>On December 23rd, 2014, 10:59 a.m. EET, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">can \
you push your work so far in a git branch? so is easy for people to try, and \
eventually contribute ;)</p></pre> </blockquote>
<p>On January 2nd, 2015, 1:27 p.m. EET, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As \
there has been no reply, I'm going to push this into master but leave the dataengine \
commented out in the CMakeLists.txt. There's no point shipping it till the plasmoid \
is done.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">To me the diff looks OK. Clearly a bit of work left, \
but what is here seems good.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sorry \
for not replying sooner, but I guess David did the better thing here. The engine \
works and I guess if people do really want to work on it (I still do), now they'll do \
it easier. On my part, I still need to get hold of the whole "devel" phase, so I'm \
slower.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Thanks David. And Happy New Year to you all.</p></pre> \
<br />
<p>- Andrei</p>
<br />
<p>On January 2nd, 2015, 1:30 p.m. EET, Andrei Amuraritei wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, David Edmundson, Marco Martin, Martin Klapetek, and \
Sebastian Kügler.</div> <div>By Andrei Amuraritei.</div>
<p style="color: grey;"><i>Updated Jan. 2, 2015, 1:30 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">comic DataEngine initial port to frameworks.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Building from source, compiles 100%, some deprecated \
warnings. DataEngine shows up in plasmaengineexplorer and detects installed .comic \
packages. This is the initial port, still need to review code to fix issues like \
whitespaces around ( or the deprecated parts. Thanks notmart, d_ed, sebas, bshas etc \
for helping.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Update: Engine is working...still need to port away \
from Solid and KService to remove KDELibs4Support, that is still wip. </p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dataengines/CMakeLists.txt <span style="color: grey">(04c7985)</span></li>
<li>dataengines/comic/CMakeLists.txt <span style="color: grey">(8e382e6)</span></li>
<li>dataengines/comic/cachedprovider.h <span style="color: \
grey">(baac8a9)</span></li>
<li>dataengines/comic/cachedprovider.cpp <span style="color: \
grey">(caca25e)</span></li>
<li>dataengines/comic/comic.h <span style="color: grey">(8cc3969)</span></li>
<li>dataengines/comic/comic.cpp <span style="color: grey">(7130f44)</span></li>
<li>dataengines/comic/comic_package.h <span style="color: \
grey">(32be381)</span></li>
<li>dataengines/comic/comic_package.cpp <span style="color: \
grey">(6d2ff0b)</span></li>
<li>dataengines/comic/comic_package_plugin.cpp <span style="color: \
grey">(d997947)</span></li>
<li>dataengines/comic/comicprovider.h <span style="color: \
grey">(630ee8d)</span></li>
<li>dataengines/comic/comicprovider.cpp <span style="color: \
grey">(ab248a5)</span></li>
<li>dataengines/comic/comicproviderkross.h <span style="color: \
grey">(46a9072)</span></li>
<li>dataengines/comic/comicproviderkross.cpp <span style="color: \
grey">(9820f05)</span></li>
<li>dataengines/comic/comicproviderwrapper.h <span style="color: \
grey">(81eee68)</span></li>
<li>dataengines/comic/comicproviderwrapper.cpp <span style="color: \
grey">(48ced42)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120276/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8988079560959204176==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic