'Re: Review Request 121790: Port plasmasehll away from kscreen'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 121790: Port plasmasehll away from kscreen
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2015-01-02 16:44:25
Message-ID: 20150102164425.30561.84386 () probe ! kde ! org
[Download RAW message or body]

--===============5386833928937114509==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On Jan. 2, 2015, 2:25 p.m., Aleix Pol Gonzalez wrote:
> > How do you figure out what's the primary screen with QScreen?
> > https://bugreports.qt-project.org/browse/QTBUG-38404
> > 
> > -2
> 
> Lukáš Tinkl wrote:
> Ugh, that's nasty, I wasn't aware of this bug...
> 
> Aleix Pol Gonzalez wrote:
> Yes, well, I don't know. People keep discussing the dependency of KScreen as if it \
> was something that happened because there was an explicit interest for using it. I \
> spent quite some time with the port and it was (and still is) the only option. 
> Fixing Qt is possible, but I'm quite sure it won't happen if we don't make it \
> happen. Changing hte Plasma side, is indeed the easy part.

ok, so focus on Qt part for now..
tough let's keep this open, that i would like having this merged when will be \
possible :)

- Marco

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121790/#review72949
-----------------------------------------------------------

On Jan. 2, 2015, noon, Lukáš Tinkl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121790/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2015, noon)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Daniel Vrátil.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This patch gets us rid of kscreen dependency in plasma-workspace. No more problems \
> with having a half usable area for the desktop or panels dancing around. \
> Plasmashell starts fine and much faster w/o kscreen installed. 
> Drawbacks:
> - QScreen currently doesn't notify of outputs added/removed when one unplugs the \
> cable or undocks the laptop 
> 
> Diffs
> -----
> 
> CMakeLists.txt c6d89c1 
> shell/CMakeLists.txt cb48ab8 
> shell/panelview.h d1ef282 
> shell/panelview.cpp b7f043d 
> shell/shellcorona.h 3321adf 
> shell/shellcorona.cpp c26efe5 
> 
> Diff: https://git.reviewboard.kde.org/r/121790/diff/
> 
> 
> Testing
> -------
> 
> To disable ext screen: xrandr --output HDMI3 --off
> To enable it again and put it right of the primary one: xrandr --output HDMI3 \
> --preferred --right-of LVDS1 
> 
> Thanks,
> 
> Lukáš Tinkl
> 
> 

--===============5386833928937114509==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/121790/">https://git.reviewboard.kde.org/r/121790/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On January 2nd, 2015, 2:25 p.m. UTC, <b>Aleix Pol \
Gonzalez</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">How do you figure out what's the primary screen with \
QScreen? https://bugreports.qt-project.org/browse/QTBUG-38404</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">-2</p></pre>  </blockquote>

 <p>On January 2nd, 2015, 2:28 p.m. UTC, <b>Lukáš Tinkl</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ugh, \
that's nasty, I wasn't aware of this bug...</p></pre>  </blockquote>

 <p>On January 2nd, 2015, 2:38 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, \
well, I don't know. People keep discussing the dependency of KScreen as if it was \
something that happened because there was an explicit interest for using it. I spent \
quite some time with the port and it was (and still is) the only option.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Fixing Qt is possible, but I'm quite sure it won't happen if we don't make \
it happen. Changing hte Plasma side, is indeed the easy part.</p></pre>  \
</blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">ok, \
so focus on Qt part for now.. tough let's keep this open, that i would like having \
this merged when will be possible :)</p></pre> <br />

<p>- Marco</p>

<br />
<p>On January 2nd, 2015, noon UTC, Lukáš Tinkl wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Daniel \
Vrátil.</div> <div>By Lukáš Tinkl.</div>

<p style="color: grey;"><i>Updated Jan. 2, 2015, noon</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch gets us rid of kscreen dependency in \
plasma-workspace. No more problems with having a half usable area for the desktop or \
panels dancing around. Plasmashell starts fine and much faster w/o kscreen \
installed.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
                inherit;white-space: inherit;">Drawbacks:
- QScreen currently doesn't notify of outputs added/removed when one unplugs the \
cable or undocks the laptop</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">To disable ext screen: xrandr --output HDMI3 --off To \
enable it again and put it right of the primary one: xrandr --output HDMI3 \
--preferred --right-of LVDS1</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(c6d89c1)</span></li>

 <li>shell/CMakeLists.txt <span style="color: grey">(cb48ab8)</span></li>

 <li>shell/panelview.h <span style="color: grey">(d1ef282)</span></li>

 <li>shell/panelview.cpp <span style="color: grey">(b7f043d)</span></li>

 <li>shell/shellcorona.h <span style="color: grey">(3321adf)</span></li>

 <li>shell/shellcorona.cpp <span style="color: grey">(c26efe5)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/121790/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5386833928937114509==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 