[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 121763: Fix build on FreeBSD
From: "Raphael Kubo da Costa" <rakuco () FreeBSD ! org>
Date: 2015-01-02 8:45:33
Message-ID: 20150102084533.30561.33834 () probe ! kde ! org
[Download RAW message or body]
--===============0693801518358176818==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Jan. 2, 2015, 10:24 a.m., Martin Gräßlin wrote:
> > Modules/info/CMakeLists.txt, lines 28-30
> > <https://git.reviewboard.kde.org/r/121763/diff/1/?file=337463#file337463line28>
> >
> > just out of interest: is devinfo a FreeBSD only library or is it of interest for \
> > more non-Linux variants?
It's a library that originated on FreeBSD (http://mdoc.su/f/devinfo.3) and as far as \
I can tell only DragonFlyBSD also uses/ships it, so I wouldn't worry about making the \
check more generic for now (I don't use DragonFly myself, but I remember some checks \
used to work for both OSes). If someone from DragonFlyBSD complains at some point, we \
can turn this into a proper Find module.
- Raphael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121763/#review72900
-----------------------------------------------------------
On Dec. 30, 2014, 8:48 p.m., Alex Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121763/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2014, 8:48 p.m.)
>
>
> Review request for Plasma and Raphael Kubo da Costa.
>
>
> Repository: kinfocenter
>
>
> Description
> -------
>
> We can't call the KCM devinfo there since we need to link against -ldevinfo
> and CMake would try to link to the KCM instead of the library in that case.
>
>
> Diffs
> -----
>
> Modules/devinfo/CMakeLists.txt 2395ce3dc83080e959cbfa9f97724218cdff6bd9
> Modules/devinfo/devinfo.desktop 1bc98a06b9a567ee45c51c7f25ee5ad6b43750d7
> Modules/info/CMakeLists.txt 7b0e0affd13d6b556749f4a350012f27fb43ae0b
> Modules/pci/CMakeLists.txt 5b2b30a0c3791a8add00a380e61469a96cd66ae1
>
> Diff: https://git.reviewboard.kde.org/r/121763/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Richardson
>
>
--===============0693801518358176818==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121763/">https://git.reviewboard.kde.org/r/121763/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 2nd, 2015, 10:24 a.m. EET, <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/121763/diff/1/?file=337463#file337463line28" \
style="color: black; font-weight: bold; text-decoration: \
underline;">Modules/info/CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">28</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">if</span><span class="p">(</span><span class="o">${</span><span \
class="nv">CMAKE_SYSTEM_NAME</span><span class="o">}</span> <span \
class="s">MATCHES</span> <span class="s2">"FreeBSD"</span><span \
class="p">)</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">29</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">target_link_libraries</span><span class="p">(</span><span \
class="s">kcm_info</span> <span class="s">devinfo</span><span \
class="p">)</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">30</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">endif</span><span class="p">()</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">just \
out of interest: is devinfo a FreeBSD only library or is it of interest for more \
non-Linux variants?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">It's a library that originated on FreeBSD (http://mdoc.su/f/devinfo.3) and \
as far as I can tell only DragonFlyBSD also uses/ships it, so I wouldn't worry about \
making the check more generic for now (I don't use DragonFly myself, but I remember \
some checks used to work for both OSes). If someone from DragonFlyBSD complains at \
some point, we can turn this into a proper Find module.</p></pre> <br />
<p>- Raphael</p>
<br />
<p>On December 30th, 2014, 8:48 p.m. EET, Alex Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Raphael Kubo da Costa.</div>
<div>By Alex Richardson.</div>
<p style="color: grey;"><i>Updated Dec. 30, 2014, 8:48 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kinfocenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">We can't call the KCM devinfo there since we need to link against \
-ldevinfo and CMake would try to link to the KCM instead of the library in that \
case.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>Modules/devinfo/CMakeLists.txt <span style="color: \
grey">(2395ce3dc83080e959cbfa9f97724218cdff6bd9)</span></li>
<li>Modules/devinfo/devinfo.desktop <span style="color: \
grey">(1bc98a06b9a567ee45c51c7f25ee5ad6b43750d7)</span></li>
<li>Modules/info/CMakeLists.txt <span style="color: \
grey">(7b0e0affd13d6b556749f4a350012f27fb43ae0b)</span></li>
<li>Modules/pci/CMakeLists.txt <span style="color: \
grey">(5b2b30a0c3791a8add00a380e61469a96cd66ae1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121763/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0693801518358176818==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic