'Re: Review Request 121771: Notify panels when dashboard is shown'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 121771: Notify panels when dashboard is shown
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2014-12-31 10:46:12
Message-ID: 20141231104612.18351.84525 () probe ! kde ! org
[Download RAW message or body]

--===============2677697350977392082==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On Dec. 31, 2014, 10:33 a.m., David Edmundson wrote:
> > IMHO, it's a bit too applicaiton specific. 
> > 
> > Given kwin does most the dashboard work, and it knows what a panel is it could do \
> > the fading.
> 
> Kai Uwe Broulik wrote:
> It perhaps is but the desktop containment knows it, too. And it is up to the \
> shellpackage to decide what to do, I don't know whether we always want to fade \
> panels in any form factor and whether we can load kwin effects based on that - \
> which is why I chose to let the panel qml file itself decide what to do.

So it does, that has convinced me. Thanks.

- David

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121771/#review72823
-----------------------------------------------------------

On Dec. 31, 2014, 10:01 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121771/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2014, 10:01 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 342123
> https://bugs.kde.org/show_bug.cgi?id=342123
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This exposes a panel.dashboardShown property similar to the desktop view which \
> allows the panels to react on it being shown. It leaves the actual reaction (hide, \
> dim, whatever) to the desktoppackage since a diferent formfactor might want to \
> handle this differently. 
> 
> Diffs
> -----
> 
> shell/panelview.h d1ef282 
> shell/panelview.cpp b7f043d 
> shell/shellcorona.cpp c26efe5 
> 
> Diff: https://git.reviewboard.kde.org/r/121771/diff/
> 
> 
> Testing
> -------
> 
> Panel can now react on it.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
> 

--===============2677697350977392082==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/121771/">https://git.reviewboard.kde.org/r/121771/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On December 31st, 2014, 10:33 a.m. UTC, <b>David \
Edmundson</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">IMHO, it's a bit too applicaiton specific. </p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Given kwin does most the dashboard work, and it knows what a panel is it \
could do the fading.</p></pre>  </blockquote>

 <p>On December 31st, 2014, 10:37 a.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It \
perhaps is but the desktop containment knows it, too. And it is up to the \
shellpackage to decide what to do, I don't know whether we always want to fade panels \
in any form factor and whether we can load kwin effects based on that - which is why \
I chose to let the panel qml file itself decide what to do.</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So it \
does, that has convinced me. Thanks.</p></pre> <br />

<p>- David</p>

<br />
<p>On December 31st, 2014, 10:01 a.m. UTC, Kai Uwe Broulik wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Dec. 31, 2014, 10:01 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=342123">342123</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This exposes a panel.dashboardShown property similar \
to the desktop view which allows the panels to react on it being shown. It leaves the \
actual reaction (hide, dim, whatever) to the desktoppackage since a diferent \
formfactor might want to handle this differently.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Panel can now react on it.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>shell/panelview.h <span style="color: grey">(d1ef282)</span></li>

 <li>shell/panelview.cpp <span style="color: grey">(b7f043d)</span></li>

 <li>shell/shellcorona.cpp <span style="color: grey">(c26efe5)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/121771/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2677697350977392082==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 