[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 121762: Fix build on FreeBSD
From: "Raphael Kubo da Costa" <rakuco () FreeBSD ! org>
Date: 2014-12-30 19:05:04
Message-ID: 20141230190504.18351.99399 () probe ! kde ! org
[Download RAW message or body]
--===============8022436577429875580==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121762/#review72792
-----------------------------------------------------------
kcms/keyboard/CMakeLists.txt
<https://git.reviewboard.kde.org/r/121762/#comment50691>
`-fexceptions` is already set above.
kcms/keyboard/flags.h
<https://git.reviewboard.kde.org/r/121762/#comment50690>
I'd move the `struct` forward declarations after the `class` ones here and in the \
other places that have been changed.
kcms/keyboard/tests/CMakeLists.txt
<https://git.reviewboard.kde.org/r/121762/#comment50692>
`-fexceptions` is already set by the `keyboard_preview_unit_tests` macro, which \
also allows you to remove the commented out line below.
kcms/phonon/CMakeLists.txt
<https://git.reviewboard.kde.org/r/121762/#comment50694>
In this case, I think it pays off to write a proper find module instead of the \
`pkg_check_module` call we currently have -- in fact, it appears I wrote one a while \
ago for KMix that's still in the repository.
In addition to the points I mentioned inline, it would be good if in your final \
commit messages you pasted the actual errors clang is throwing at you for posterity.
- Raphael Kubo da Costa
On Dec. 30, 2014, 8:35 p.m., Alex Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121762/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2014, 8:35 p.m.)
>
>
> Review request for Plasma and Raphael Kubo da Costa.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Fix build with clang 3.4
>
> Clang doesn't allow variable length arrays of non-POD data types
> Also it seems that the default template instantion depth is not
> enough to compile geometry_parser.cpp
>
> ------
>
> Add missing includes of cmath and cstdlib
>
> -----
>
> Fix clang warning -Wmismatched-tags
>
> -----
>
>
> Fix build of geometry_parser test with clang
>
> We need to increase the template instantiation depth
>
> -----
>
> Fix more -Wmismatched-tag warnings
>
> ----
>
> Fix build of kapplymousetheme if X11 isn't installed to /usr
>
> ----
>
>
> Fix build of phonon KCM if libcanberra is not in /usr
>
>
> Diffs
> -----
>
> kcms/keyboard/bindings.h d59790752ced2ec8fd77269f75012e74ccda4cc4
> kcms/keyboard/flags.h 3957a983f06044e8f5ed130afc4774f8c644ed8c
> kcms/keyboard/kcm_add_layout_dialog.h a2c0ac5ebc264d69555063668cb68be5255b3030
> kcms/keyboard/kcm_keyboard.h c88fe3dd8540df07eb886b3119dfbe30fab2844b
> kcms/keyboard/kcm_keyboard_widget.h 5994ea4815d6398afaf6765b77a2bc8cd349f780
> kcms/keyboard/kcm_view_models.h 872e26185248c6dfb8d8808115865ae18596cbea
> kcms/keyboard/kcmmisc.cpp 9aed7de2a8a63aa546dc9484eea0edadcc64ec66
> containments/folder/plugin/positioner.cpp c24827197bf20b4cb55a6b885f023074f179159c
> kcms/input/CMakeLists.txt a2b72a45a3b694b7fa367abf33d0752b0dc9734b
> kcms/keyboard/CMakeLists.txt 3db5dc3f938bbe25259067783bda4fdd882f60f6
> kcms/keyboard/keyboard_daemon.h 4d7587f9113edea31dd07f23d658818941731df2
> kcms/keyboard/layout_tray_icon.h 8338bf26307627747fb434ae8e0903050142aef4
> kcms/keyboard/layouts_menu.h db2f3ff5844e16340ad3ca6102e6b1c4866ad8db
> kcms/keyboard/preview/kbpreviewframe.cpp 9735eb02ac6875bb3905fb0bf8183a9d97e0e3e4
> kcms/keyboard/tests/CMakeLists.txt bd62c7d281766bc5c04b0b1e933861d258241cf7
> kcms/keyboard/xkb_helper.h d3dab1d9b05784ae463db44ab941119e5b214986
> kcms/phonon/CMakeLists.txt 8f964e2041cc812bf70f6a48e2915427f088b990
>
> Diff: https://git.reviewboard.kde.org/r/121762/diff/
>
>
> Testing
> -------
>
> compiles
>
>
> Thanks,
>
> Alex Richardson
>
>
--===============8022436577429875580==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121762/">https://git.reviewboard.kde.org/r/121762/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/121762/diff/1/?file=337446#file337446line127" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kcms/keyboard/CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">127</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">set_source_files_properties</span><span class="p">(</span><span \
class="s">preview/geometry_parser.cpp</span> <span class="s">PROPERTIES</span> <span \
class="s">COMPILE_FLAGS</span> <span class="s2">"-ftemplate-depth=512 \
-fexceptions"</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">-fexceptions</code> is already set above.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/121762/diff/1/?file=337448#file337448line32" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kcms/keyboard/flags.h</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">32</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n"><span \
class="hl">class</span></span> <span class="n">LayoutUnit</span><span \
class="p">;</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">32</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="k"><span \
class="hl">struct</span></span> <span class="n">LayoutUnit</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'd \
move the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">struct</code> forward declarations after the \
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">class</code> ones here and in the other \
places that have been changed.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/121762/diff/1/?file=337458#file337458line52" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kcms/keyboard/tests/CMakeLists.txt</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">52</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">set_source_files_properties</span><span class="p">(</span><span \
class="s">../preview/geometry_parser.cpp</span> <span class="s">PROPERTIES</span> \
<span class="s">COMPILE_FLAGS</span> <span class="s2">"-ftemplate-depth=512 \
-fexceptions"</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">-fexceptions</code> is already set by the <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">keyboard_preview_unit_tests</code> macro, which also allows \
you to remove the commented out line below.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/121762/diff/1/?file=337460#file337460line46" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kcms/phonon/CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">46</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nb">link_directories</span><span class="p">(</span><span \
class="o">${</span><span class="nv">CANBERRA_LIBRARY_DIRS</span><span \
class="o">}</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In \
this case, I think it pays off to write a proper find module instead of the <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">pkg_check_module</code> call we currently have -- in fact, \
it appears I wrote one a while ago for KMix that's still in the repository.</p></pre> \
</div> </div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In \
addition to the points I mentioned inline, it would be good if in your final commit \
messages you pasted the actual errors clang is throwing at you for \
posterity.</p></pre>
<p>- Raphael Kubo da Costa</p>
<br />
<p>On December 30th, 2014, 8:35 p.m. EET, Alex Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Raphael Kubo da Costa.</div>
<div>By Alex Richardson.</div>
<p style="color: grey;"><i>Updated Dec. 30, 2014, 8:35 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Fix build with clang 3.4</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Clang \
doesn't allow variable length arrays of non-POD data types Also it seems that the \
default template instantion depth is not enough to compile geometry_parser.cpp</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: \
1px solid #ddd;line-height: inherit;" /> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Add missing includes of \
cmath and cstdlib</p> <hr style="text-rendering: inherit;margin: 0;padding: \
0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" /> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Fix clang warning -Wmismatched-tags</p> <hr style="text-rendering: \
inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: \
inherit;" /> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Fix build of geometry_parser test with clang</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">We need to increase the template instantiation depth</p> <hr \
style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px \
solid #ddd;line-height: inherit;" /> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix more \
-Wmismatched-tag warnings</p> <hr style="text-rendering: inherit;margin: 0;padding: \
0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" /> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Fix build of kapplymousetheme if X11 isn't installed to /usr</p> <hr \
style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px \
solid #ddd;line-height: inherit;" /> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix build of phonon KCM \
if libcanberra is not in /usr</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">compiles</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/keyboard/bindings.h <span style="color: \
grey">(d59790752ced2ec8fd77269f75012e74ccda4cc4)</span></li>
<li>kcms/keyboard/flags.h <span style="color: \
grey">(3957a983f06044e8f5ed130afc4774f8c644ed8c)</span></li>
<li>kcms/keyboard/kcm_add_layout_dialog.h <span style="color: \
grey">(a2c0ac5ebc264d69555063668cb68be5255b3030)</span></li>
<li>kcms/keyboard/kcm_keyboard.h <span style="color: \
grey">(c88fe3dd8540df07eb886b3119dfbe30fab2844b)</span></li>
<li>kcms/keyboard/kcm_keyboard_widget.h <span style="color: \
grey">(5994ea4815d6398afaf6765b77a2bc8cd349f780)</span></li>
<li>kcms/keyboard/kcm_view_models.h <span style="color: \
grey">(872e26185248c6dfb8d8808115865ae18596cbea)</span></li>
<li>kcms/keyboard/kcmmisc.cpp <span style="color: \
grey">(9aed7de2a8a63aa546dc9484eea0edadcc64ec66)</span></li>
<li>containments/folder/plugin/positioner.cpp <span style="color: \
grey">(c24827197bf20b4cb55a6b885f023074f179159c)</span></li>
<li>kcms/input/CMakeLists.txt <span style="color: \
grey">(a2b72a45a3b694b7fa367abf33d0752b0dc9734b)</span></li>
<li>kcms/keyboard/CMakeLists.txt <span style="color: \
grey">(3db5dc3f938bbe25259067783bda4fdd882f60f6)</span></li>
<li>kcms/keyboard/keyboard_daemon.h <span style="color: \
grey">(4d7587f9113edea31dd07f23d658818941731df2)</span></li>
<li>kcms/keyboard/layout_tray_icon.h <span style="color: \
grey">(8338bf26307627747fb434ae8e0903050142aef4)</span></li>
<li>kcms/keyboard/layouts_menu.h <span style="color: \
grey">(db2f3ff5844e16340ad3ca6102e6b1c4866ad8db)</span></li>
<li>kcms/keyboard/preview/kbpreviewframe.cpp <span style="color: \
grey">(9735eb02ac6875bb3905fb0bf8183a9d97e0e3e4)</span></li>
<li>kcms/keyboard/tests/CMakeLists.txt <span style="color: \
grey">(bd62c7d281766bc5c04b0b1e933861d258241cf7)</span></li>
<li>kcms/keyboard/xkb_helper.h <span style="color: \
grey">(d3dab1d9b05784ae463db44ab941119e5b214986)</span></li>
<li>kcms/phonon/CMakeLists.txt <span style="color: \
grey">(8f964e2041cc812bf70f6a48e2915427f088b990)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121762/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8022436577429875580==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic