[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 121761: Fix build on FreeBSD
From: "Raphael Kubo da Costa" <rakuco () FreeBSD ! org>
Date: 2014-12-30 18:42:13
Message-ID: 20141230184213.18351.21958 () probe ! kde ! org
[Download RAW message or body]
--===============5329190004579272441==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121761/#review72789
-----------------------------------------------------------
I'd keep the `errno.h` includes alphabetically sorted, and commit each of those \
changes (errno, then X11 dependencies etc) separately. Other than that, looks good to \
me.
- Raphael Kubo da Costa
On Dec. 30, 2014, 8:33 p.m., Alex Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121761/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2014, 8:33 p.m.)
>
>
> Review request for Plasma and Raphael Kubo da Costa.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Add missing errno.h include
>
> Wrap Linux-only signals in #ifdef Q_OS_LINUX
>
> Fix build with X11 not installed to /usr
>
>
> Diffs
> -----
>
> drkonqi/detachedprocessmonitor.cpp 85a87874c6e9ce47856a01195b42aef9f3a4991a
> drkonqi/systeminformation.cpp 8f5fc7fe789a4bbe23f178e7e940ba1d1a1b59db
> ksmserver/CMakeLists.txt 84a8aa393dfb6ed4671094d1fccbb3c79c53f9af
> ksmserver/screenlocker/greeter/authenticator.cpp \
> ad60f0bd0076cd9c8c3875f13dc92b5da253bb1a \
> ksmserver/screenlocker/greeter/autotests/killtest.cpp \
> 6f2ef114459b5d641e357f3a817b82e7af2e72a3 libkworkspace/CMakeLists.txt \
> 53ce6108bd91f87108206fca02ac303dadf069e1
> Diff: https://git.reviewboard.kde.org/r/121761/diff/
>
>
> Testing
> -------
>
> compiles, still compiles on linux
>
>
> Thanks,
>
> Alex Richardson
>
>
--===============5329190004579272441==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121761/">https://git.reviewboard.kde.org/r/121761/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'd \
keep the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">errno.h</code> includes alphabetically \
sorted, and commit each of those changes (errno, then X11 dependencies etc) \
separately. Other than that, looks good to me.</p></pre> <br />
<p>- Raphael Kubo da Costa</p>
<br />
<p>On December 30th, 2014, 8:33 p.m. EET, Alex Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Raphael Kubo da Costa.</div>
<div>By Alex Richardson.</div>
<p style="color: grey;"><i>Updated Dec. 30, 2014, 8:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Add missing errno.h include</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Wrap \
Linux-only signals in #ifdef Q_OS_LINUX</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix build with X11 not \
installed to /usr</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">compiles, still compiles on linux</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>drkonqi/detachedprocessmonitor.cpp <span style="color: \
grey">(85a87874c6e9ce47856a01195b42aef9f3a4991a)</span></li>
<li>drkonqi/systeminformation.cpp <span style="color: \
grey">(8f5fc7fe789a4bbe23f178e7e940ba1d1a1b59db)</span></li>
<li>ksmserver/CMakeLists.txt <span style="color: \
grey">(84a8aa393dfb6ed4671094d1fccbb3c79c53f9af)</span></li>
<li>ksmserver/screenlocker/greeter/authenticator.cpp <span style="color: \
grey">(ad60f0bd0076cd9c8c3875f13dc92b5da253bb1a)</span></li>
<li>ksmserver/screenlocker/greeter/autotests/killtest.cpp <span style="color: \
grey">(6f2ef114459b5d641e357f3a817b82e7af2e72a3)</span></li>
<li>libkworkspace/CMakeLists.txt <span style="color: \
grey">(53ce6108bd91f87108206fca02ac303dadf069e1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121761/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5329190004579272441==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic